Activity
From 11/14/2019 to 11/20/2019
11/20/2019
-
10:28 PM Revision 8f106212 (git): Add test/reline/test_string_processing.rb
-
- https://github.com/ruby/reline/commit/09d370bdc19e62f0a27c2240e19b07963afd922f
-
-
-
-
08:58 PM Feature #16356: Method#inspect of argument forwarding
- @jeremyevans0 thanks for the explanation, I suspected there is something important about missing `:keyrest` there :)
But names (e.g. literal `:*` and `:&`) should be excluded from `parameters` output anyways, right?.. -
08:30 PM Feature #16356: Method#inspect of argument forwarding
- zverok (Victor Shepelev) wrote:
> `#inspect` just follows whatever `#parameters` say.
> ...
That's not how `...` is implemented, though. It is implemented so that:
```ruby
def a(...)
b(...)
end
```
means
```ruby
ruby2... -
- `#inspect` just follows whatever `#parameters` say.
But I indeed find that `#parameters` return value is kinda weird for this case:
```
./ruby --disable-gems -e "def m(...); end; p method(:m).parameters"
[[:rest, :*], [:block, :... -
10:58 AM Feature #16356 (Open): Method#inspect of argument forwarding
- Current behavior includes `(**, &&)`.
Is this intentional?
```
% ruby -e 'def mf(...);end;p method(:mf)'
#<Method: main.mf(**, &&) -e:1>
```
I added tests of current behavior at https://github.com/ruby/ruby/commit/777973084e599... -
08:07 PM Feature #16355: Raise NoMatchingPatternError when `expr in pat` doesn't match
- Agree, that it could save users from unexpected behavior.
On the other hand, raising an exception drastically limits the application of online pattern matching: it won't be possible to use it with `if ... else ...` or in `select/filte... -
12:58 AM Feature #16355 (Closed): Raise NoMatchingPatternError when `expr in pat` doesn't match
- Currently, single line pattern matching(`expr in pat`) returns true or false.
```
[1, 2, 3] in [x, y, z] #=> true (with assigning 1 to x, 2 to y, and 3 to z)
[1, 2, 3] in [1, 2, 4] #=> false
```
I think `expr in pat` should rais... -
07:38 PM Revision 1197a036 (git): Add a proper cast to pass JIT tests on mswin.
- https://ci.appveyor.com/project/ruby/ruby/builds/29001248/job/ye80bsrmewdgw294
-
- 05:44 PM Revision 9d6f7882 (git): Refactor filter_backtrace
- 05:44 PM Revision 04d0d93e (git): Fix filter_backtrace for context-mode 0
-
-
05:18 PM Revision 9b52bacc (git): Refined inspection of argument forwarding
- 03:48 PM Revision f835a74d (git): * 2019-11-21 [ci skip]
-
03:47 PM Revision 6723aa07 (git): Change argument `Proc` to `#call` defined object.
- This is the same as the behavior of Readline.
-
-
11:14 AM Bug #16357 (Closed): `Segmentation fault (core dumped)` or `[BUG] object allocation during garbage collection phase`
- How to reproduce:
```
+$ tree .
.
โโโ config.ru
โโโ Gemfile
โโโ Gemfile.lock
0 directories, 3 files
+$ cat config.ru
require 'json'
require 'rack'
run ->(env) do
begin
req = Rack::Request.new(env)
JSON.load(... -
- https://github.com/seattlerb/minitest/pull/798 is closed.
-
- You can use `String#-@` and `String#+@` in method chain.
```ruby
"foo".-@.size
ary.to_s.+@.frozen?
``` -
-
-
-
- `rb_resolve_refined_method_callable` is referenced in
`refine_sym_proc_call`, even when pre-compiling mjit header on
mswin. -
- Warned at making precompiled header on mswin.
```
building rb_mjit_header-2.7.0.pch
vm.c
d:\a\ruby\ruby\src\vm_args.c(1117): warning C4047: '=': 'const rb_callable_method_entry_t *' differs in levels of indirection from 'int'
rb_mjit_he... -
06:54 AM Revision 7608baf9 (git): re-add function prototypes
- This commit reverts a part of 0e8219f591f3f17cb7ee361e8a60dbef08145883
which broke icc. See also https://rubyci.org/logs/rubyci.s3.amazonaws.com/icc-x64/ruby-master/log/20191120T010006Z.fail.html.gz -
-
- This one can be closed (`Enumerator#produce` was implemented in 2.7)
-
- @hsbt
>> what's the maintenance status of the upstream?
> ...
I just noticed my documentation patches [#349](https://github.com/flori/json/pull/349) and [#347](https://github.com/flori/json/pull/347) and clarification request [#348... -
- merged. Thank you!
-
- @ko1 I've updated the PR to use `...` and `_`, and rebased it from recent `master`.
-
-
-
- Example:
def m(a, b=nil, *c, d:, e: nil, **rest, &block)
end
p method(:m)
#=> #<Method: m(a, b=<default>, *c, d:, e: <default>, **rest, &block) ...> -
- This behaviour has been there since the beginning. No ruby version since 0.49 has successfully dumped such long string. Same thing happens for a very big bignum, a very long array, a class that has very long classpath (Q::W::E::R::...)...
-
-
-
- meth do # the preceding token of "do" has EXPR_CMDARG
end
meth() do # the preceding token of "do" has EXPR_ENDFN
end
11/19/2019
-
-
-
- Applied in changeset commit:git|ff41663403d3eb76d95f465cb94e14d2faaa04d1.
----------
Fix memory corruption in Enumerable#reverse_each [ruby-dev:50867] [Bug #16354] -
- Enumerable#reverse_eachใฎใใญใใฏๅผใณๅบใไธญใซใๅฏพ่ฑกใฎEnumerableใto_aใใใใฎใๆใพใใฆใตใคใบใๅคๆดใใใจSEGVใใใใจใใใใพใใ
```
$ ruby -e '(0...1000).reverse_each {|i| i.inspect; ObjectSpace.each_object(Array) {|a| a.clear if a.length == 1000 }}'
-e:1: [BUG] Segmentatio... -
-
- @ko1 I happened to sit next to Matz on speakers' lunch at RubyConf and asked him (just in case). He agreed to both of your proposals, so I'll change it in a day or two in my patch :)
Thank you! -
- Great patch!
I think `<default>` is too long. How about `...`?
```
def foo9 a, b, o1=nil, *args, p1, k1:nil, rk1:, **kw, &bl
end
p method(:foo9)
#<Method: main.foo9(a, b, o1=..., *args, p1, rk1:, k1:..., **kw, &bl) /home/ko1/src/... -
- This reverts commit 0b8c73aa65add5c57b46b0cfdf4e661508802172, which
seems breaking RVALUE consistency check. - 03:07 PM Revision f3c98035 (git): * 2019-11-20 [ci skip]
-
-
- and rename from b.rb
[ruby-core:95055] [Bug #16177] -
-
- Sorry, we can not write enough discussion log.
At least for me, real time English logging is hard.
I hope enough information are added for each ticket.
Good idea or your help is welcome. -
- I fixed this issue, but no test. can anyone write it?
-
- Applied in changeset commit:git|a5fe08fdd9d11f12a6837291ee588ab933a823b6.
----------
care about TAG_FATAL.
TAG_FATAL represents interpreter closing state and ec->errinfo
contains FIXNUM (eTerminateSignal, etc). If we need to change the... -
- TAG_FATAL represents interpreter closing state and ec->errinfo
contains FIXNUM (eTerminateSignal, etc). If we need to change the
state, then errinfo is also changed because TAG_RAISE assumes that
ec->errinfo contains a Exception object.
... -
- Please backport 2a477e0e444de6344048101466fb9189b9defddc to ruby_2_5.
It may avoid occasional errors on macos.
https://github.com/ruby/actions/runs/309307228#step:17:201
```
1) Error:
FTPTest#test_retrbinary_read_timeout_not_exc... -
- Get rid of races in parallel configuration when using the
ext/Setup file. -
- Some minor optimizations.
Calculating -------------------------------------
ours trunk
vm2_regexp 8.479M 8.346M i/s - 6.000M times in 0.707612s 0.718916s
vm2_regexp_invert ... -
- Dan0042 (Daniel DeLorme) wrote:
> > - Possibility #3: renders SyntaxError. This requires a massive rewrite of our parser. Theoretically possible but not in practice.
> ...
It may be possible to know at runtime whether a literal block... -
- https://github.com/seattlerb/minitest/pull/798 is closed
-
- These functions are used from within a compilation unit so we can
make them static, for better binary size. This changeset reduces
the size of generated ruby binary from 26,590,128 bytes to
26,584,472 bytes on my macihne. - 02:40 AM Revision 78e266da (git): Clarify documentation for `InstructionSequence#compile`.
- We incorrectly assumed that the `file` argument should be the file name and
caused https://github.com/scoutapp/scout_apm_ruby/issues/307 because
exception backtrace did not contain correct path. This documentation
clarifies the role of t...
11/18/2019
-
06:01 PM Feature #13083: Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- knu (Akinori MUSHA) wrote:
> I'm a bit surprised and confused. The change that has been made is not what this issue was originally about, and actually the opposite, I think.
Per matz's decision: https://bugs.ruby-lang.org/issues/130... -
01:36 PM Feature #13083: Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- I'm a bit surprised and confused. The change that has been made is not what this issue was originally about, and actually the opposite, I think.
I believe many of us have got used to the original behavior, that is, methods of a Regex... -
- `stty` called in `Reline::ANSI.deprep` command shows the following
error message on macOS Apple Terminal, with some settings.
```
$ LANG=C irb
irb(main):001:0>
stty: 'standard input': unable to perform all requested operations
stty: 'st... -
-
05:31 PM Revision 0be0d90a (git): pack is not using invokebuiltin anymore
-
-
-
- 03:27 PM Revision 9067f43c (git): * 2019-11-19 [ci skip]
-
03:25 PM Revision 0c0278b9 (git): test/-ext-/string/test_fstring.rb: suppress a warning for taint
-
-
-
-
01:16 PM Feature #15563: #dig that throws an exception if a key doesn't exist
- Removed the two discussion points in the previous edit. This edit adjusts the last sentence to reflect this.
-
- Changed naming from `#dig_e` to `#traverse`. Removed alternative options, and kept the strict version since `#fetch` is also strict. Possibility to expand upon this with a block or `:default` keyword argument is possible, but should be i...
-
11:39 AM Feature #16352 (Open): Modify Marshal to dump objects larger than 2 GiB
- Using a gem called Numo-array to handle matrix operations, I found the following error while saving a large matrix:
```
in `dump': long too big to dump (TypeError)
```
Github thread is https://github.com/ruby-numo/numo-narray/iss... -
-
-
-
- Suppress compiler warnings.
-
- > Some internal transient heap structs moved to the header file now leaks into all other reference sites where this source file (transient_heap.c) as previously just used for API
not a big issue, but I don't want to expose them...
-
-
-
- I think this is a documentation bug, since the comment makes it explicit that shifting is always disabled if shift_age is 0. I submitted a pull request to update the documentation: https://github.com/ruby/logger/pull/43 .
-
03:42 AM Feature #16348: Proposal: Symbol#start_with?, Symbol#end_with?, and Symbol#include?
- I personally think that we should be restrictive in adding new methods to `Symbol`. Otherwise, this very quickly becomes a slippery slope, and the distinction between `Symbol` and `String` becomes less and less clear.
I was personally... -
- naruse (Yui NARUSE) wrote:
> ```diff
> ...
`str` should be `sym`. -
-
- add casts to avoid compile error.
http://ci.rvm.jp/results/trunk_clang_39@silicon-docker/2402215 -
- Array#pack uses `opt_invokebuiltin_delegate_leave` now.
-
- opt_invokebuiltin_delegate and opt_invokebuiltin_delegate_leave
invokes builtin functions with same parameters of the method.
This technique eliminate stack push operations. However, delegation
parameters should be completely same as giv... -
- https://travis-ci.org/ruby/ruby/jobs/613242256#L2205
11/17/2019
-
- Looks like the forwardable keyword argument support was never merged. My previous attempt, developed before `ruby2_keywords`, added `**kw` to method definition and method calls on 2.7+. I've updated the pull request to use `ruby2_keywo...
-
- I merged these changes at commit:4c7dc9fbe604cc0c8343b1225c96d4e5219b8147 . Still one failing CI test, but the same one that is failing in the master branch for a few days, related to makefile dependencies.
- 11:00 PM Revision b7539298 (git): * remove trailing spaces. [ci skip]
-
11:00 PM Revision 4c7dc9fb (git): Update NEWS for $SAFE/taint changes
-
-
- rb_eval_cmd takes a safe level, and now that $SAFE is deprecated,
it should be deprecated as well.
Replace with rb_eval_cmd_kw, which takes a keyword flag. Switch
the two callers to this function. -
- Ruby 2.7 deprecates taint and it no longer has an effect.
The lack of taint support should not cause a problem in
previous Ruby versions. -
- Ruby 2.7 deprecates taint and it no longer has an effect.
The lack of taint support should not cause a problem in
previous Ruby versions. -
- Ruby 2.7 deprecates taint and it no longer has an effect.
The lack of taint support should not cause a problem in
previous Ruby versions. -
- Ruby 2.7 deprecates taint and it no longer has an effect.
The lack of taint support should not cause a problem in
previous Ruby versions.
Still untaint the tmpdir object on Ruby <2.7, as returning
a tainted string there could cause prob... -
- Ruby 2.7 deprecates taint and it no longer has an effect.
-
- Ruby 2.7 deprecates taint and it no longer has an effect.
-
-
- This removes the related tests, and puts the related specs behind
version guards. This affects all code in lib, including some
libraries that may want to support older versions of Ruby. -
- This removes the security features added by $SAFE = 1, and warns for access
or modification of $SAFE from Ruby-level, as well as warning when calling
all public C functions related to $SAFE.
This modifies some internal functions that to... - 06:25 PM Revision 7b6a8b5b (git): * 2019-11-18 [ci skip]
-
-
- nobu (Nobuyoshi Nakada) wrote:
> By changing the last calling line as the following with making that `initialize` method public, you could observe the same numbers as `FooWithPlainParams`.
> ...
I'd like to add a note: `allocate.initia... -
- `FooWithKeyword#initialize` method is not called directly, but via `Class#new`.
A `Hash` is needed to delegate the keyword arguments.
By changing the last calling line as the following with making that `initialize` method public, you c... -
12:54 PM Bug #16351 (Closed): Why do Keyword arguments to initialize allocate a Hash, but not for other methods?
- Hello, while working on improving memory allocations in one of my apps, I stumbled upon the following behavior. I measured three different ways of passing variables to a new `Object`, using plain params, using a hash and using keyword ar...
-
- https://github.com/ruby/irb/commit/0180dc74bc
-
- https://github.com/ruby/irb/commit/4945d0e676
-
- https://github.com/ruby/reline/commit/d57c7ea252
-
02:20 PM Feature #16348: Proposal: Symbol#start_with?, Symbol#end_with?, and Symbol#include?
- ```diff
diff --git a/string.c b/string.c
index 554aabad4b..d53fdc89fd 100644
--- a/string.c
+++ b/string.c
@@ -11166,6 +11166,64 @@ sym_swapcase(int argc, VALUE *argv, VALUE sym)
return rb_str_intern(rb_str_swapcase(argc, argv... -
- sam.saffron (Sam Saffron) wrote:
> A lot faster than no warning at all? Was just concerned looking up the callsite and a hashtable lookup might have some sort of cost. Also this technically will leak memory for the lifetime of the proce... - 04:12 AM Revision a8e4a9f0 (git): * 2019-11-17 [ci skip]
-
11/16/2019
-
10:58 PM Feature #16345: Don't emit deprecation warnings by default.
- > It's actually a lot faster
A lot faster than no warning at all? Was just concerned looking up the callsite and a hashtable lookup might have some sort of cost. Also this technically will leak memory for the lifetime of the process.... -
- sam.saffron (Sam Saffron) wrote:
> Sure! will give it a shot next week, also want to double check we don't see any noticeable perf impact for all the accounting.
It's actually a lot faster with deduplicated warnings, see my comment o... -
- > any chance you could try https://github.com/ruby/ruby/pull/2458 and let us know how many warnings are reported for Discourse?
Sure! will give it a shot next week, also want to double check we don't see any noticeable perf impact fo... -
-
05:20 PM Feature #16350 (Assigned): ArithmeticSequence#member? can result in infinite loop
- I'm not sure if this is a bug or a feature, it feels somewhere in between.
This is my first time contributing to the Ruby code, let me know what I can improve in this report!
ArithmeticSequence#member? enumerates through the sequen...
11/15/2019
-
08:41 PM Feature #16347: InmutableObject
- dvarrui (David Vargas) wrote:
> Thanks!
> ...
-
Thanks!
Good document.
I didnt know deep_freeze. Its nice!-
- shyouhei (Shyouhei Urabe) wrote:
> I prefer the way requested in this ticket, but #16289 is practically an acceptable solution to me.
Then let's do #16289 then, I agree that's a good solution to mitigate too many warnings.
-
03:02 AM Feature #16345: Don't emit deprecation warnings by default.
- Dan0042 (Daniel DeLorme) wrote:
> Personally I'd like to have this feature as an attribute accessor of `Warning`. So it's easier to set the value based on configuration.
> ...
Apart from environment variable based configuration,
such ... -
- shyouhei (Shyouhei Urabe) wrote:
> In short: yes, warn iff not seen before can be an acceptable option.
I strongly urge the approach taken in #16289 then. It seems to be the best compromise that still notifies users about problems t... -
- In short: yes, warn iff not seen before can be an acceptable option.
jeremyevans0 (Jeremy Evans) wrote:
> The logical conclusion of this reasoning is that no deprecation warnings should ever be added, since any deprecation warning co... -
- I updated https://github.com/ruby/ruby/pull/2476. There are a couple failing CI tests, both of which appear unrelated:
* https://ci.appveyor.com/project/ruby/ruby/builds/28875336/job/6udjor0n25yvgaan
* https://travis-ci.org/ruby/rub... -
- https://github.com/ruby/reline/commit/98b72af751
-
-
06:22 AM Feature #15665: Cannot compile socket extension on Mojave
- naruse (Yui NARUSE) wrote:
> Usually -pedantic is applied automatically ruby core but not passed to extension libraries.
> ...
I knew that Ruby was compiled with `-pedantic`; wasnโt aware that this was for core only. Thanks a lot for t... -
-
01:09 AM Bug #16349 (Assigned): Logger shift_age of 0 disables shift_size
-
12:48 AM Bug #16349 (Closed): Logger shift_age of 0 disables shift_size
- shift_age is documented as: Number of old log files to keep, or frequency of rotation (daily, weekly or monthly). Default value is 0.
shift_size is documented: Maximum logfile size in bytes (only applies when shift_age is a number). Def...
11/14/2019
- 06:56 PM Revision 018be445 (git): * 2019-11-15 [ci skip]
-
- The script in prelude.rb was embed in MRI to load it (eval this
script at everyboot).
This commit change the loading process of prelude.rb. MRI doesn't
eval a script, but load from compiled binary with builtin feature.
So that Init_prel... -
06:21 PM Feature #16336: Allow private constants to be accessed with absolute references
- https://bugs.ruby-lang.org/issues/16123 added support for making private methods calls explicitly through `self`, so in class `A` `self.b` could be used to call a private class method `b`. If consistency with private methods is desired,...
-
04:14 PM Feature #13083: Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- Dan0042 wrote:
> Is there a benefit to the change apart from consistency? A concrete benefit I mean.
This is only one point of view.
Sometimes there are "wrong" use cases or use cases that were not anticipated by the core team. ... -
- I have no particular pro/con opinion. When it comes to class `Symbol`, though, I believe
that this is is a design decision for matz. I understand that some of the comments
in the other threads are related to rails, but the suggestion h... -
- Looking at the list of symbols inside of libruby-static.a, I found
hundreds of functions that are defined, but used from nowhere.
There can be reasons for each of them (e.g. some functions are
specific to some platform, some are useful ... -
- sam.saffron (Sam Saffron) wrote:
> > I'm against not emitting deprecation warnings by default.
> ...
I'm OK with eliminating duplicate warnings, or stopping warning after a certain number of warnings emitted. Not necessarily in favor... -
-
-
-
-
03:46 AM Misc #16262: DevelopersMeeting20191128Japan
- - [Bug #15620] Block argument usage affects lambda semantic
- I find the current behaviour unreasonably confusing and would like to see improvement, even though the bug doesn't really show up in the real world often.
- I have a [pu... -
03:45 AM Bug #16288: Segmentation fault with finalizers, threads
- This code pretty reliably produces a segmentation fault on my machine:
```
require 'timeout'
Thread.DEBUG = 1
class Foo
def initialize
ObjectSpace.define_finalizer(self, proc do
Foo.f...