libpq: Add missing OAuth translations
authorJacob Champion <jchampion@postgresql.org>
Mon, 15 Dec 2025 21:17:10 +0000 (13:17 -0800)
committerJacob Champion <jchampion@postgresql.org>
Mon, 15 Dec 2025 21:17:10 +0000 (13:17 -0800)
commitea3370b18ebea536a100ae6dce25add3f5eb6565
tree0783a79ea21221b139ae2e583272e9b933ca2e73
parent48d4a1423d2e92d10077365532d92e059ba2eb2e
libpq: Add missing OAuth translations

Several strings that should have been translated as they passed through
libpq_gettext were not actually being pulled into the translation files,
because I hadn't directly wrapped them in one of the GETTEXT_TRIGGERS.

Move the responsibility for calling libpq_gettext() to the code that
sets actx->errctx. Doing the same in report_type_mismatch() would result
in double-translation, so mark those strings with gettext_noop()
instead. And wrap two ternary operands with gettext_noop(), even though
they're already in one of the triggers, since xgettext sees only the
first.

Finally, fe-auth-oauth.c was missing from nls.mk, so none of that file
was being translated at all. Add it now.

Original patch by Zhijie Hou, plus suggested tweaks by Γlvaro Herrera
and small additions by me.

Reported-by: Zhijie Hou <houzj.fnst@fujitsu.com>
Author: Zhijie Hou <houzj.fnst@fujitsu.com>
Co-authored-by: Álvaro Herrera <alvherre@kurilemu.de>
Co-authored-by: Jacob Champion <jacob.champion@enterprisedb.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/TY4PR01MB1690746DB91991D1E9A47F57E94CDA%40TY4PR01MB16907.jpnprd01.prod.outlook.com
Backpatch-through: 18
src/interfaces/libpq-oauth/oauth-curl.c
src/interfaces/libpq/nls.mk