Don't include access/htup_details.h in executor/tuptable.h
authorÁlvaro Herrera <alvherre@kurilemu.de>
Sun, 5 Oct 2025 16:00:38 +0000 (18:00 +0200)
committerÁlvaro Herrera <alvherre@kurilemu.de>
Sun, 5 Oct 2025 16:00:38 +0000 (18:00 +0200)
commit1a8b5b11e48a8fb086228542d1d4b379f23bdc1e
tree06588c3d9bfd065bd5a20bcc15f93dc8fe37ad6b
parent1b6f61bd89889f704656005e7c1f1a40255230e5
Don't include access/htup_details.h in executor/tuptable.h

This is not at all needed; I suspect it was a simple mistake in commit
5408e233f066.  It causes htup_details.h to bleed into a huge number of
places via execnodes.h.  Remove it and fix fallout.

Discussion: https://postgr.es/m/202510021240.ptc2zl5cvwen@alvherre.pgsql
33 files changed:
contrib/pageinspect/btreefuncs.c
contrib/pageinspect/gistfuncs.c
contrib/pg_stat_statements/pg_stat_statements.c
contrib/pg_walinspect/pg_walinspect.c
contrib/postgres_fdw/connection.c
contrib/xml2/xslt_proc.c
src/backend/access/common/printsimple.c
src/backend/access/common/printtup.c
src/backend/access/common/tupconvert.c
src/backend/backup/walsummaryfuncs.c
src/backend/catalog/pg_attrdef.c
src/backend/catalog/pg_largeobject.c
src/backend/catalog/pg_parameter_acl.c
src/backend/commands/explain_dr.c
src/backend/commands/proclang.c
src/backend/commands/statscmds.c
src/backend/executor/nodeGatherMerge.c
src/backend/executor/nodeMemoize.c
src/backend/executor/tstoreReceiver.c
src/backend/optimizer/path/indxpath.c
src/backend/optimizer/util/pathnode.c
src/backend/parser/parse_coerce.c
src/backend/parser/parse_expr.c
src/backend/utils/adt/arrayfuncs.c
src/backend/utils/adt/hbafuncs.c
src/backend/utils/adt/json.c
src/backend/utils/adt/misc.c
src/backend/utils/adt/rangetypes.c
src/backend/utils/adt/xid8funcs.c
src/backend/utils/fmgr/fmgr.c
src/backend/utils/misc/guc.c
src/include/executor/tuptable.h
src/test/modules/injection_points/injection_stats_fixed.c