Don't Insert() a VFD entry until it's fully built.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 17 Nov 2020 01:32:35 +0000 (20:32 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 17 Nov 2020 01:32:35 +0000 (20:32 -0500)
commit214f22823f2033330853d35740fddea315f88b64
tree13e3e5a981093c67398b3ec9b2e82d51833861af
parentc8961de1456f77d0c6875f91958045adac5a2bb2
Don't Insert() a VFD entry until it's fully built.

Otherwise, if FDDEBUG is enabled, the debugging output fails because
it tries to read the fileName, which isn't set up yet (and should in
fact always be NULL).

AFAICT, this has been wrong since Berkeley.  Before 96bf88d52,
it would accidentally fail to crash on platforms where snprintf()
is forgiving about being passed a NULL pointer for %s; but the
file name intended to be included in the debug output wouldn't
ever have shown up.

Report and fix by Greg Nancarrow.  Although this is only visibly
broken in custom-made builds, it still seems worth back-patching
to all supported branches, as the FDDEBUG code is pretty useless
as it stands.

Discussion: https://postgr.es/m/CAJcOf-cUDgm9qYtC_B6XrC6MktMPNRby2p61EtSGZKnfotMArw@mail.gmail.com
src/backend/storage/file/fd.c