Fix incorrect lack of Datum conversion in _int_matchsel()
authorPeter Eisentraut <peter@eisentraut.org>
Fri, 8 Aug 2025 10:06:06 +0000 (12:06 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Fri, 8 Aug 2025 10:10:45 +0000 (12:10 +0200)
commit276cdd4cc37845b31fb9048c4f32eeb33ae60e1a
treed15e0b2b8024e62b23e267b79374635495d0b0cf
parente028ce911ad21e23ca39555e01a2d6c41c76aa79
Fix incorrect lack of Datum conversion in _int_matchsel()

The code used

    return (Selectivity) 0.0;

where

    PG_RETURN_FLOAT8(0.0);

would be correct.

On 64-bit systems, these are pretty much equivalent, but on 32-bit
systems, PG_RETURN_FLOAT8() correctly produces a pointer, but the old
wrong code would return a null pointer, possibly leading to a crash
elsewhere.

We think this code is actually not reachable because bqarr_in won't
accept an empty query, and there is no other function that will
create query_int values.  But better be safe and not let such
incorrect code lie around.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/8246d7ff-f4b7-4363-913e-827dadfeb145%40eisentraut.org
contrib/intarray/_int_selfuncs.c