Fix assorted core dumps and Assert failures that could occur during
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 24 Jan 2010 21:49:39 +0000 (21:49 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 24 Jan 2010 21:49:39 +0000 (21:49 +0000)
commit7309f3340c46bdb8109e0465becbc078b1e1858a
tree93ab7462a25c2fa10eedf38d2a46221ed9fc3479
parent61da9c4e2520b3ec4735c8eee1c3adbe9c697ca2
Fix assorted core dumps and Assert failures that could occur during
AbortTransaction or AbortSubTransaction, when trying to clean up after an
error that prevented (sub)transaction start from completing:
* access to TopTransactionResourceOwner that might not exist
* assert failure in AtEOXact_GUC, if AtStart_GUC not called yet
* assert failure or core dump in AfterTriggerEndSubXact, if
  AfterTriggerBeginSubXact not called yet

Per testing by injecting elog(ERROR) at successive steps in StartTransaction
and StartSubTransaction.  It's not clear whether all of these cases could
really occur in the field, but at least one of them is easily exposed by
simple stress testing, as per my accidental discovery yesterday.
src/backend/access/transam/xact.c
src/backend/commands/trigger.c
src/backend/utils/misc/guc.c