Fix rare bug in read_stream.c's split IO handling.
authorThomas Munro <tmunro@postgresql.org>
Sat, 9 Aug 2025 00:33:06 +0000 (12:33 +1200)
committerThomas Munro <tmunro@postgresql.org>
Sat, 9 Aug 2025 01:06:46 +0000 (13:06 +1200)
commit9110d81641696b95ea55f3a15dd0907ec0743529
tree22ec78ae53a394dd6879a1b5d218b72d724f0827
parent762fed90bfee248ca090a96fe883e063ba035088
Fix rare bug in read_stream.c's split IO handling.

The internal queue of buffers could become corrupted in a rare edge case
that failed to invalidate an entry, causing a stale buffer to be
"forwarded" to StartReadBuffers().  This is a simple fix for the
immediate problem.

A small API change might be able to remove this and related fragility
entirely, but that will have to wait a bit.

Defect in commit ed0b87ca.

Bug: 19006
Backpatch-through: 18
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Xuneng Zhou <xunengzhou@gmail.com>
Discussion: https://postgr.es/m/19006-80fcaaf69000377e%40postgresql.org
src/backend/storage/aio/read_stream.c