Remove XLogFileInit() ability to skip ControlFileLock.
authorNoah Misch <noah@leadboat.com>
Tue, 29 Jun 2021 01:34:55 +0000 (18:34 -0700)
committerMichael Paquier <michael@paquier.xyz>
Sun, 6 Apr 2025 05:22:46 +0000 (14:22 +0900)
commitdf8ec9634ccdc3c67871e36fcc54c44370639b37
tree60b6cbf6c52ddd55ba98070d2831af5d1d13f5e7
parente276b58293d59f3c560e3322c1ac5b2c0e39af94
Remove XLogFileInit() ability to skip ControlFileLock.

Cold paths, initdb and end-of-recovery, used it.  Don't optimize them.

This commit has been applied as of c53c6b98d38a in v15 and newer
versions.  This is required on stable branches of v13 and v14 to fix a
regression reported by Noah Misch, introduced by 1f95181b44c8, causing
spurious failures in archive recovery (neither streaming nor archive
recovery) with concurrent restartpoints.  The backpatched versions of
the patches have been aligned on these branches by me, Noah Misch is the
author.  Tests have been conducted by the both of us.

Reported-by: Arun Thirupathi
Author: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com
Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com
Backpatch-through: 13
src/backend/access/transam/xlog.c
src/backend/replication/walreceiver.c
src/include/access/xlog.h