Fix resource leak while reading startup packet.

Per Coverity.

Backpatch-through: v4.2

diff --git a/src/protocol/child.c b/src/protocol/child.c
index 2f4935e7063c57035339e4807e71363b4b8ff235..c83d537d16cdcd641398cc63bb575f0996ca935d 100644 (file)
--- a/src/protocol/child.c
+++ b/src/protocol/child.c
@@ -5,7 +5,7 @@
  * pgpool: a language independent connection pool server for PostgreSQL
  * written by Tatsuo Ishii
  *
- * Copyright (c) 2003-2024     PgPool Global Development Group
+ * Copyright (c) 2003-2025     PgPool Global Development Group
  *
  * Permission to use, copy, modify, and distribute this software and
  * its documentation for any purpose and without fee is hereby
@@ -753,9 +753,12 @@ read_startup_packet(POOL_CONNECTION * cp)
                                 errdetail("no PostgreSQL user name specified in startup packet")));
        }
 
-       /* The database defaults to ther user name. */
-       if (sp->database == NULL || sp->database[0] == '\0')
+       /* The database defaults to their user name. */
+       if (sp->database == NULL)
+               sp->database = pstrdup(sp->user);
+       else if (sp->database[0] == '\0')
        {
+               pfree(sp->database);
                sp->database = pstrdup(sp->user);
        }