From: Tatsuo Ishii <ishii@postgresql.org>
Date: Sun, 11 Aug 2024 06:36:37 +0000 (+0900)
Subject: Fix another bug in replication mode and snapshot isolation mode.
X-Git-Tag: V4_5_4~6
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=7a2737c5a389c17cad00794cc9fbc421a525ac9a;p=pgpool2.git

Fix another bug in replication mode and snapshot isolation mode.

This is a follow up commit for 181d300de6337fe9a10b60ddbd782aa886b563e9.

If previous query produces parameter status message, subsequent
parse() needs to read and process it because it wants to read Ready
for query message which is supposed to follow the parameter status
message.  However when ParameterStatus() gets called, the query in
progress flag was set and it was possible that only one of parameter
status message from backend was processed if the query processed in
this parse() call is load balanced. It is likely that the parameter
status message comes from all live backend because they are generated
by SET command, and SET command are sent to all live backend in
replication mode and snapshot isolation mode. So unset the query in
progress flag before calling ParameterStatus().

Here is the test case written in pgproto data format.

'P'	""	"SET application_name TO foo"
'B'	""	""	0	0	0
'E'	""	0
'P'	""	"SELECT 1"
'B'	""	""	0	0	0
'E'	""	0
'P'	""	"SET application_name TO bar"
'B'	""	""	0	0	0
'E'	""	0
'S'
'Y'
'X'

Backpatch-through: v4.1.
---

diff --git a/src/protocol/pool_proto_modules.c b/src/protocol/pool_proto_modules.c
index 1ad29650b..1bebe8e7a 100644
--- a/src/protocol/pool_proto_modules.c
+++ b/src/protocol/pool_proto_modules.c
@@ -1470,6 +1470,12 @@ Parse(POOL_CONNECTION * frontend, POOL_CONNECTION_POOL * backend,
 		{
 			int			i;
 
+			/*
+			 * Temporarily unset query in progress so that all live backend
+			 * are processed.
+			 */
+			pool_unset_query_in_progress();
+
 			/* synchronize transaction state */
 			for (i = 0; i < NUM_BACKENDS; i++)
 			{