From: Robert Treat <rob@xzilla.net>
Date: Wed, 7 Oct 2020 04:30:51 +0000 (-0400)
Subject: Clean up pass by ref warnings in constraints tab
X-Git-Tag: REL_7-13-0~5
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=a818cca6bfe15128615381bd7dcf5999f216b913;p=phppgadmin.git

Clean up pass by ref warnings in constraints tab
---

diff --git a/constraints.php b/constraints.php
index cc1591c9..dcc3e94e 100644
--- a/constraints.php
+++ b/constraints.php
@@ -55,7 +55,8 @@
 
 					if ($attrs->recordCount() > 0) {
 						while (!$attrs->EOF) {
-							$selColumns->add(new XHTML_Option($attrs->fields['attname']));
+							$XHTML_Option = new XHTML_Option($attrs->fields['attname']);
+							$selColumns->add($XHTML_Option);
 							$attrs->moveNext();
 						}
 					}
@@ -158,7 +159,8 @@
 
 				if ($attrs->recordCount() > 0) {
 					while (!$attrs->EOF) {
-						$selColumns->add(new XHTML_Option($attrs->fields['attname']));
+						$XHTML_Option = new XHTML_Option($attrs->fields['attname']);
+						$selColumns->add($XHTML_Option);
 						$attrs->moveNext();
 					}
 				}
@@ -251,7 +253,8 @@
 
 			if ($attrs->recordCount() > 0) {
 				while (!$attrs->EOF) {
-					$selColumns->add(new XHTML_Option($attrs->fields['attname']));
+					$XHTML_Option = new XHTML_Option($attrs->fields['attname']);
+					$selColumns->add($XHTML_Option);
 					$attrs->moveNext();
 				}
 			}