From: Jean-Michel Vourgère <nirgal@debian.org>
Date: Sun, 20 Oct 2019 10:42:24 +0000 (+0200)
Subject: Print an error if mbstring extension is missing
X-Git-Tag: REL_7-12-1~10
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=aeeb7c3911dc0776fe0c8f10604bab9765588f82;p=phppgadmin.git

Print an error if mbstring extension is missing

Generic missing extension messages
---

diff --git a/lang/english.php b/lang/english.php
index c232a752..9414113d 100644
--- a/lang/english.php
+++ b/lang/english.php
@@ -177,7 +177,8 @@
 	$lang['strnoframes'] = 'This application works best with a frames-enabled browser, but can be used without frames by following the link below.';
 	$lang['strnoframeslink'] = 'Use without frames';
 	$lang['strbadconfig'] = 'Your config.inc.php is out of date. You will need to regenerate it from the new config.inc.php-dist.';
-	$lang['strnotloaded'] = 'Your PHP installation does not support PostgreSQL. You need to recompile PHP using the --with-pgsql configure option.';
+	$lang['strlibnotfound'] = 'Your PHP installation does not support the %s module. You will need to install, enable, or compile it to use phpPgAdmin.';
+	$lang['strlibnotfound_plural'] = 'Your PHP installation does not support the %s modules. You will need to install, enable, or compile them to use phpPgAdmin.';
 	$lang['strpostgresqlversionnotsupported'] = 'Version of PostgreSQL not supported. Please upgrade to version %s or later.';
 	$lang['strbadschema'] = 'Invalid schema specified.';
 	$lang['strbadencoding'] = 'Failed to set client encoding in database.';
diff --git a/libraries/lib.inc.php b/libraries/lib.inc.php
index 4494680d..80c62a10 100644
--- a/libraries/lib.inc.php
+++ b/libraries/lib.inc.php
@@ -208,9 +208,19 @@
 		exit;
 	}
 
-	// Check database support is properly compiled in
-	if (!function_exists('pg_connect')) {
-		echo $lang['strnotloaded'];
+	// Check php libraries
+	$php_libraries_requirements = [
+		// required_function => name_of_the_php_library
+		'pg_connect' => 'pgsql',
+		'mb_strlen' => 'mbstring'];
+	$missing_libraries = [];
+	foreach($php_libraries_requirements as $funcname => $lib)
+		if (!function_exists($funcname))
+			$missing_libraries[] = $lib;
+	if ($missing_libraries) {
+		$missing_list = implode(', ', $missing_libraries);
+		$error_missing_template_string = count($missing_libraries) <= 1 ? $lang['strlibnotfound'] : $lang['strlibnotfound_plural'];
+		printf($error_missing_template_string, $missing_list);
 		exit;
 	}