From 33aff5cc4f986ecf59ade5eea58aa45a74144d20 Mon Sep 17 00:00:00 2001 From: Tatsuo Ishii Date: Sat, 9 Nov 2024 15:33:26 +0900 Subject: [PATCH] Revert "Fix Pgpool-II child process crash during shutdown." This reverts commit 2b0ba0f30631b6e8604910542b218abb8107b1be. Per discussion: [pgpool-general: 9265] Re: Segmentation fault during shutdown https://www.pgpool.net/pipermail/pgpool-general/2024-November/001942.html --- src/protocol/child.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/protocol/child.c b/src/protocol/child.c index 4e2a3443b..c12a5a2c1 100644 --- a/src/protocol/child.c +++ b/src/protocol/child.c @@ -1350,12 +1350,9 @@ child_will_go_down(int code, Datum arg) memcached_disconnect(); } - /* - * We used to call close_all_backend_connections() here so that we send - * 'X' (terminate) message to backend. However it was possible that the - * function is called while initializing the connection pool object, which - * leads to crash. So we stopped to call close_all_backend_connections(). - */ + /* let backend know now we are exiting */ + if (pool_connection_pool) + close_all_backend_connections(); } /* -- 2.39.5