From 99ca54013d4fb0e8197468b15ce702ff85013354 Mon Sep 17 00:00:00 2001
From: Tatsuo Ishii <ishii@postgresql.org>
Date: Sun, 25 Aug 2024 10:13:57 +0900
Subject: [PATCH] Revert "Doc: mention that reloading is not necessary when
 pool_passwd is updated."

This reverts commit 6c7f9ff640432b99fa11726c0db66ea3c7e15c9d.

"reloading is not necessary when pool_passwd is updated." was not
correct. Since reading pool_passwd in pgpool uses a buffered read,
it's too fragile to assume that changes to pool_passwd by different
process is immediately available for pgpool process. To reflect the
changes, pgpool reload (which causes re-opening pool_passwd). is
necessary.

Discussion: [pgpool-general: 9185] reloading of pool_passwd file
https://www.pgpool.net/pipermail/pgpool-general/2024-August/001862.html
---
 doc.ja/src/sgml/client-auth.sgml         |  6 ++----
 doc.ja/src/sgml/connection-settings.sgml |  1 -
 doc/src/sgml/client-auth.sgml            | 10 ++++++----
 doc/src/sgml/connection-settings.sgml    |  5 +----
 4 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/doc.ja/src/sgml/client-auth.sgml b/doc.ja/src/sgml/client-auth.sgml
index 9511716ed..ab5bde966 100644
--- a/doc.ja/src/sgml/client-auth.sgml
+++ b/doc.ja/src/sgml/client-auth.sgml
@@ -891,8 +891,7 @@
      3- After changing md5 password(in both pool_passwd and <productname>PostgreSQL</> of course),
      reload the <productname>Pgpool-II</> configurations.
      -->
-     3. pool_passwdと<productname>PostgreSQL</>の両方でmd5パスワードを変更します。
-	<productname>Pgpool-II</>設定の再読み込みは必要ありません。
+     3. （もちろんpool_passwdと<productname>PostgreSQL</>の両方で）md5パスワードを変更したら、<productname>Pgpool-II</>設定の再読み込みを実行してください。
     </para>
    </sect3>
 
@@ -1008,8 +1007,7 @@
      and <productname>PostgreSQL</productname> of course), reload
      the <productname>Pgpool-II</productname> configuration.
      -->
-     3. pool_passwdと<productname>PostgreSQL</>の両方でmd5パスワードを変更します。
-	<productname>Pgpool-II</>設定の再読み込みは必要ありません。
+     3- （もちろんpool_passwdと<productname>PostgreSQL</productname>の両方で）SCRAMパスワードを変更したら、<productname>Pgpool-II</productname>の設定の再読み込みを実行してください。
     </para>
    </sect3>
 
diff --git a/doc.ja/src/sgml/connection-settings.sgml b/doc.ja/src/sgml/connection-settings.sgml
index 21ee4b689..1ecae3172 100644
--- a/doc.ja/src/sgml/connection-settings.sgml
+++ b/doc.ja/src/sgml/connection-settings.sgml
@@ -622,7 +622,6 @@
       This parameter can only be set at server start.
       -->
       このパラメータはサーバ起動時にのみ設定可能です。
-      ただし、パスワードファイルの内容変更はサーバの再起動や設定ファイルの再読込なしに直ちに反映されます。
      </para>
     </listitem>
    </varlistentry>
diff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client-auth.sgml
index 0b8ea3379..6441be083 100644
--- a/doc/src/sgml/client-auth.sgml
+++ b/doc/src/sgml/client-auth.sgml
@@ -660,8 +660,9 @@
      See <xref linkend="auth-pool-hba-conf"> for more details.
     </para>
     <para>
-     3- Change md5 password in both pool_passwd and <productname>PostgreSQL</productname>.
-     Reloading the pgpool configurations is not necessary.
+     3- After changing md5 password (in both pool_passwd
+     and <productname>PostgreSQL</productname> of course), reload
+     the pgpool configurations.
     </para>
    </sect3>
 
@@ -739,8 +740,9 @@
      See <xref linkend="auth-pool-hba-conf"> for more details.
     </para>
     <para>
-     3- Change md5 password in both pool_passwd and <productname>PostgreSQL</productname>.
-     Reloading the pgpool configurations is not necessary.
+     3- After changing SCRAM password (in both pool_passwd
+     and <productname>PostgreSQL</productname> of course), reload
+     the <productname>Pgpool-II</productname> configuration.
     </para>
    </sect3>
 
diff --git a/doc/src/sgml/connection-settings.sgml b/doc/src/sgml/connection-settings.sgml
index 8d2a77d59..0bdfa500e 100644
--- a/doc/src/sgml/connection-settings.sgml
+++ b/doc/src/sgml/connection-settings.sgml
@@ -385,7 +385,7 @@
       e.g. <literal>TEXTmypassword</literal>
      </para>
      <para>
-      Similarly md5 hashed passwords must be prefixed with <literal>md5</literal> and
+      similarly md5 hashed passwords must be prefixed with <literal>md5</literal> and
       AES256 encrypted password types can be stored using <literal>AES</literal> prefix.
       see <xref linkend="auth-aes-encrypted-password"> for more details on using
        AES256 encrypted passwords.
@@ -397,9 +397,6 @@
      </para>
      <para>
       This parameter can only be set at server start.
-      However, you don't need to restart the server or reload the
-      configuration file when you update the contents of the password
-      file.
      </para>
     </listitem>
    </varlistentry>
-- 
2.39.5