libpq: Prevent some overflows of int/size_t
authorJacob Champion <jchampion@postgresql.org>
Mon, 10 Nov 2025 14:03:05 +0000 (06:03 -0800)
committerJacob Champion <jchampion@postgresql.org>
Mon, 10 Nov 2025 14:03:05 +0000 (06:03 -0800)
commit96d2c7e96e8bb6563b0b6e0d8d02162ed67ff12e
tree424ae187cc4e14e242d8151f0a33fcc8760059cf
parente792be6f43bcb2ea5a7a3ca4dd2139a925cbb491
libpq: Prevent some overflows of int/size_t

Several functions could overflow their size calculations, when presented
with very large inputs from remote and/or untrusted locations, and then
allocate buffers that were too small to hold the intended contents.

Switch from int to size_t where appropriate, and check for overflow
conditions when the inputs could have plausibly originated outside of
the libpq trust boundary. (Overflows from within the trust boundary are
still possible, but these will be fixed separately.) A version of
add_size() is ported from the backend to assist with code that performs
more complicated concatenation.

Reported-by: Aleksey Solovev (Positive Technologies)
Reviewed-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Security: CVE-2025-12818
Backpatch-through: 13
src/interfaces/libpq/fe-connect.c
src/interfaces/libpq/fe-exec.c
src/interfaces/libpq/fe-print.c
src/interfaces/libpq/fe-protocol3.c
src/interfaces/libpq/libpq-int.h