bdr: command filter enhancements and fixes

Forbidding renaming of ALTER AGGREGATE … RENAME TO …, ALTER COLLATION …
RENAME TO …, ALTER CONVERSION … RENAME TO …, ALTER OPERATOR CLASS …
RENAME TO …, ALTER OPERATOR FAMILY … RENAME TO …. Forbidding ALTER
TABLESPACE … MOVE …, too.

diff --git a/contrib/bdr/bdr_commandfilter.c b/contrib/bdr/bdr_commandfilter.c
index 7fc500dffe1d97326d5544927b5cb84d1055c3f2..f0fdd88a35da6152ada16b4f92e8cd5f2d074e95 100644 (file)
--- a/contrib/bdr/bdr_commandfilter.c
+++ b/contrib/bdr/bdr_commandfilter.c
@@ -473,8 +473,26 @@ bdr_commandfilter(Node *parsetree,
            break;
 
        case T_DropStmt:
+           break;
+
        case T_RenameStmt:
-           /* FIXME: catch unsupported rename operations */
+           {
+               RenameStmt *n = (RenameStmt *)parsetree;
+
+               switch(n->renameType)
+               {
+               case OBJECT_AGGREGATE:
+               case OBJECT_COLLATION:
+               case OBJECT_CONVERSION:
+               case OBJECT_OPCLASS:
+               case OBJECT_OPFAMILY:
+                   error_unsupported_command(CreateCommandTag(parsetree));
+                   break;
+
+               default:
+                   break;
+               }
+           }
            break;
 
        case T_AlterObjectSchemaStmt:
@@ -482,7 +500,7 @@ bdr_commandfilter(Node *parsetree,
            break;
 
        case T_AlterTableSpaceMoveStmt:
-           /* XXX: forbid? */
+           error_unsupported_command("ALTER TABLESPACE ... MOVE");
            break;
 
        case T_AlterOwnerStmt: