Don't try to do feedback on sessions without start time
authorMagnus Hagander <magnus@hagander.net>
Wed, 21 May 2025 15:41:43 +0000 (17:41 +0200)
committerMagnus Hagander <magnus@hagander.net>
Wed, 21 May 2025 15:41:43 +0000 (17:41 +0200)
These sessions aren't listed in the session list or schedule, but if
they are linked to externally we would allow them and then crash later
when checking the starttime. So instead of crashing, just disallow the
feedback form on sessions that shouldn't have it.

postgresqleu/confreg/views.py

index 112c27789fa856769bc21d454aa625e6ab09d313..19c96f1b51c1046fff40418035a8a673e56d2c0c 100644 (file)
@@ -1134,7 +1134,7 @@ def feedback(request, confname):
 def feedback_session(request, confname, sessionid):
     # Room for optimization: don't get these as separate steps
     conference = get_conference_or_404(confname)
-    session = get_object_or_404(ConferenceSession, pk=sessionid, conference=conference, status=1)
+    session = get_object_or_404(ConferenceSession, pk=sessionid, conference=conference, status=1, can_feedback=True, starttime__isnull=False)
 
     if not conference.feedbackopen:
         # Allow conference testers to override