From 824c76980602fbfe74242df921517de351accbd4 Mon Sep 17 00:00:00 2001 From: Magnus Hagander Date: Wed, 21 May 2025 17:41:43 +0200 Subject: [PATCH] Don't try to do feedback on sessions without start time These sessions aren't listed in the session list or schedule, but if they are linked to externally we would allow them and then crash later when checking the starttime. So instead of crashing, just disallow the feedback form on sessions that shouldn't have it. --- postgresqleu/confreg/views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/postgresqleu/confreg/views.py b/postgresqleu/confreg/views.py index 112c2778..19c96f1b 100644 --- a/postgresqleu/confreg/views.py +++ b/postgresqleu/confreg/views.py @@ -1134,7 +1134,7 @@ def feedback(request, confname): def feedback_session(request, confname, sessionid): # Room for optimization: don't get these as separate steps conference = get_conference_or_404(confname) - session = get_object_or_404(ConferenceSession, pk=sessionid, conference=conference, status=1) + session = get_object_or_404(ConferenceSession, pk=sessionid, conference=conference, status=1, can_feedback=True, starttime__isnull=False) if not conference.feedbackopen: # Allow conference testers to override -- 2.39.5