fix: change keyword plugin and import regexp#3668
Merged
Merged
Conversation
edhgoose
reviewed
Nov 19, 2021
Contributor
edhgoose
left a comment
There was a problem hiding this comment.
This looks correct to me - thank you.
I'm not sure if a test already exists for this, but perhaps another test to confirm that the plugin and import must be proceeded by the @ symbol and followed by a space might be a good idea? I don't think I can see tests that prove this?
Same for perhaps ensuring that they're at the beginning of a line too? This may be going too far, but might help if anyone changes these regexes in the future.
edhgoose
approved these changes
Nov 19, 2021
matthew-dean
approved these changes
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix #3660
less.js/packages/less/src/less/parser/parser.js
Line 1687 in a4b6c85
less.js/packages/less/src/less/parser/parser.js
Line 1847 in a4b6c85
ready for code review, cc @matthew-dean . btw, i add
.DS_Storeinto.gitignore