The stream argument must implement #<<.#1959
Merged
Merged
Conversation
jeremyevans
approved these changes
Aug 31, 2022
Contributor
jeremyevans
left a comment
There was a problem hiding this comment.
I originally thought it would best to only add this restriction on callable bodies (i.e. not for hijack), as that approach would not introduce backwards compatibility issues. However, I guess there is no really issue with also doing so for hijack, and there is an advantage in keeping things consistent between the two (callable bodies operating exactly the same as partial hijack currently).
Member
Author
|
I understand. I've deliberately tried to keep rack partial hijack and rack streaming response semantics identical to make it easier for server implementor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to use the stream argument with template systems like ERB, Trenni, etc for real time template streaming/generation.