Skip to content

feat: Support user-defined formatter.log before GCP formatting#200

Merged
nielm merged 3 commits into
GoogleCloudPlatform:mainfrom
maou-shonen:feat-Support-user-defined-formatter.log-after-GCP-formatting
Aug 5, 2025
Merged

feat: Support user-defined formatter.log before GCP formatting#200
nielm merged 3 commits into
GoogleCloudPlatform:mainfrom
maou-shonen:feat-Support-user-defined-formatter.log-after-GCP-formatting

Conversation

@maou-shonen
Copy link
Copy Markdown
Contributor

pino-logging-gcp-config

This PR allows formatter.log to be executed after GCP formatting,
so users can customize the log object on top of the GCP format.

@nielm
Copy link
Copy Markdown
Collaborator

nielm commented Jul 17, 2025

Can you add some documentation on this feature to the readme please.

Would it make more sense to run the existing formatter before the GCP formatter?

@maou-shonen maou-shonen changed the title feat: Support user-defined formatter.log after GCP formatting feat: Support user-defined formatter.log before GCP formatting Jul 17, 2025
@maou-shonen
Copy link
Copy Markdown
Contributor Author

You're absolutely right, it does make more sense to run the existing formatter first,
I've updated the code accordingly.

I also update README

@nielm nielm merged commit 9fa3d97 into GoogleCloudPlatform:main Aug 5, 2025
2 checks passed
ChaosEternal pushed a commit that referenced this pull request Aug 5, 2025
This PR allows formatter.log to be executed before GCP formatting,
so users can customize the log object before applying the GCP format.

Change-Id: I6b805b006bb30bc7d0481249a086f18a6006de37
GitOrigin-RevId: 1430369a70f28dc96b4cbcb57a25624a1b972a63
@nielm
Copy link
Copy Markdown
Collaborator

nielm commented Aug 7, 2025

Pushed to npmjs - apologies for the delay.

@maou-shonen maou-shonen deleted the feat-Support-user-defined-formatter.log-after-GCP-formatting branch August 7, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants