Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e89f0421bcab
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: abeab897a29c
Choose a head ref
  • 5 commits
  • 9 files changed
  • 4 contributors

Commits on Oct 23, 2023

  1. Roll Skia from 4976279e4441 to d534571c4bc3 (1 revision) (#47231) 

    https://skia.googlesource.com/skia.git/+log/4976279e4441..d534571c4bc3

2023-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from e7c82ebc0260 to e2319672168f (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    e20f46e View commit details
    Browse the repository at this point in the history

  2. [Impeller] Vk query cleanups. (#47208) 

    Use RAII to more accurately capture cmd buffer start/end, with additional protections for early frame ending. This also allows us to capture the execution time of the final cmd buffer, which should fix flutter/flutter#136971
    Jonah Williams authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    88b054a View commit details
    Browse the repository at this point in the history

  3. Add missing headers to the fml source_set. (#47232) 

    These being missing came up when internal build rules were being derived from the ones here.
    @chinmaygarde
    chinmaygarde authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    19ed039 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from d534571c4bc3 to 73e9879f06e7 (1 revision) (#47233) 

    https://skia.googlesource.com/skia.git/+log/d534571c4bc3..73e9879f06e7

2023-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from ec29008ac6cf to 6188c0a69c93 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    f2009ef View commit details
    Browse the repository at this point in the history

  5. [Impeller] Added tests to assert empty saveLayer behaviors. (#47138) 

    fixes: flutter/flutter#126391

It turns out certain cases listed in the issue already render correctly.
This adds tests to assert that we maintain that behavior.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @gaaclarke
    gaaclarke authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    abeab89 View commit details
    Browse the repository at this point in the history
Loading