Skip to content

feat: show possible correct key(s) in .__getitem__ KeyError message #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 23, 2024
Merged

feat: show possible correct key(s) in .__getitem__ KeyError message #1097

merged 6 commits into from
Oct 23, 2024

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Oct 21, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #328113227 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 21, 2024
@arwas11 arwas11 requested a review from tswast October 21, 2024 21:04
tswast
tswast reviewed Oct 22, 2024
View reviewed changes
tswast
tswast reviewed Oct 22, 2024
View reviewed changes
@arwas11 arwas11 requested a review from tswast October 23, 2024 15:56
@arwas11 arwas11 marked this pull request as ready for review October 23, 2024 15:58
@arwas11 arwas11 requested review from a team as code owners October 23, 2024 15:58
tswast
tswast approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 23, 2024
@tswast tswast enabled auto-merge (squash) October 23, 2024 16:48
@tswast tswast merged commit 32fab96 into main Oct 23, 2024
17 of 23 checks passed
@tswast tswast deleted the b328113227-groupby-getitme-cloumn-name-error branch October 23, 2024 16:58
@release-please release-please bot mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@rey-esp rey-esp

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arwas11 @tswast @rey-esp