Skip to content

fix: Fix issues where duration type returned as int #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 1, 2025
Merged

fix: Fix issues where duration type returned as int #1875

merged 9 commits into from
Jul 1, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 30, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jun 30, 2025
@TrevorBergeron TrevorBergeron requested a review from sycai July 1, 2025 01:31
@TrevorBergeron TrevorBergeron changed the title test: Integrate duration type into more tests fix: Fix issues where duration type returned as int Jul 1, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review July 1, 2025 01:32
@TrevorBergeron TrevorBergeron requested review from a team as code owners July 1, 2025 01:32
sycai
sycai previously approved these changes Jul 1, 2025
View reviewed changes
@GarrettWu GarrettWu removed their assignment Jul 1, 2025
@TrevorBergeron TrevorBergeron requested a review from sycai July 1, 2025 20:47
@TrevorBergeron TrevorBergeron merged commit f30f750 into main Jul 1, 2025
21 of 25 checks passed
@TrevorBergeron TrevorBergeron deleted the duration_in_scalars branch July 1, 2025 20:58
@release-please release-please bot mentioned this pull request Jul 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sycai sycai sycai approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @sycai @GarrettWu