Skip to content

feat: Add config option to set partial ordering mode #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2024
Merged

feat: Add config option to set partial ordering mode #855

merged 2 commits into from
Jul 25, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 23, 2024
@TrevorBergeron TrevorBergeron requested a review from tswast July 23, 2024 20:50
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jul 23, 2024
@TrevorBergeron TrevorBergeron marked this pull request as ready for review July 24, 2024 21:46
@TrevorBergeron TrevorBergeron requested review from a team as code owners July 24, 2024 21:46
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 24, 2024
@tswast tswast merged commit 823c0ce into main Jul 25, 2024
@tswast tswast deleted the ordering_mode_config branch July 25, 2024 21:50
@release-please release-please bot mentioned this pull request Jul 25, 2024
Merged
tswast
tswast reviewed Jul 30, 2024
View reviewed changes
bigframes/_config/bigquery_options.py
import bigframes.exceptions


class OrderingMode(Enum):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move this to bigframes.enums? https://github.com/googleapis/python-bigquery-dataframes/blob/main/bigframes/enums.py

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mailed #870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@liujiashang liujiashang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @tswast @liujiashang