Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: logstash-plugins/logstash-output-http
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: logstash-plugins/logstash-output-http
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feature/ssl-configuration
Choose a head ref
  • 5 commits
  • 5 files changed
  • 1 contributor

Commits on Jun 4, 2015

  1. Additional SSL configuration

    This makes the `verify_ssl` setting function. It also adds a new
    setting `ssl_version` which lets you choose the SSL/TLS version
    to handshake.
    jordansissel committed Jun 4, 2015
    Configuration menu
    Copy the full SHA
    6bf3ea2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1be604d View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2015

  1. Configuration menu
    Copy the full SHA
    9045c0f View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2015

  1. Add test coverage for all supported TLS versions

    This test suite will test all permutations of these TLS/SSL versions and
    expect aligned versions to succeed and misaligned versions to fail.
    
    'aligned' means both client and server are choosing the same TLS/SSL
    protocol version. 'misaligned' means they choose different versions.
    Example, a TLS v1.1 client would reject an SSLv3 server.
    jordansissel committed Jun 23, 2015
    1 Configuration menu
    Copy the full SHA
    8c29b75 View commit details
    Browse the repository at this point in the history
  2. Add ssl certificate fixtures.

    I'm having trouble generating SSL certificates from within JRuby that
    JRuby can use. I'd get this error from the client:
    
    > OpenSSL::SSL::SSLError: Received fatal alert: internal_error
    
    Upon deeper inspection, I'd see this on the server side:
    
    > OpenSSL::SSL::SSLError: java.io.IOException: Invalid encoding of
    AuthorityKeyIdentifierExtension.
    
    MRI passes the tests where JRuby does not. Additionally, openssl
    s_client seems happy to serve with the same certificate that JRuby
    doesn't like. Weird.
    
    For now, we'll hard-code some basic certificates until I can find a
    workaround or fix it in JRuby.
    jordansissel committed Jun 23, 2015
    Configuration menu
    Copy the full SHA
    78fe8da View commit details
    Browse the repository at this point in the history
Loading