Skip to content

json parser: Fix error case#22

Merged
f-f merged 3 commits into
masterfrom
json-fix
Jun 8, 2025
Merged

json parser: Fix error case#22
f-f merged 3 commits into
masterfrom
json-fix

Conversation

@anttih
Copy link
Copy Markdown
Contributor

@anttih anttih commented May 5, 2025

In the case of an error, we didn't actually return the either, the call order is wrong.

@anttih anttih requested a review from f-f May 6, 2025 04:14
@anttih anttih changed the title Fix parsing error case json parser: Fix error case May 6, 2025
Copy link
Copy Markdown
Contributor

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are good 😄

@f-f f-f merged commit b985b62 into master Jun 8, 2025
1 check passed
@f-f f-f deleted the json-fix branch June 8, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants