Compiler/0.12#20
Merged
Merged
Conversation
changes for 0.12
The underlying implementation in `node/lib/internal/child_process.js` does
return a boolean value, but this value is devoid of any semantic content.
Shortened it does:
```
if childProcessHandle {
res = child.kill(signal)
if (res === 0) {
child.killed = true;
return true;
else {
throwError()
}
}
else {
return false;
}
```
which means the returned boolean depends on whether the subprocess still exists
and whether the signal was successfully sent (apparently the original author
thought that sending a signal will always kill the process).
The return value isn’t even mentioned in the documentation, so it must be a
historical artifact kept around for backward compatibility.
According to the node documentation: “`'close'` is distinct from the 'exit' event, since multiple processes might share the same stdio streams.” https://nodejs.org/api/child_process.html#child_process_event_close
Merged
Contributor
|
Is there something more needed here? |
Every exposed symbol should be documented now.
Improve docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picked and merged open PRs.
Closes #11
Closes #12
Closes #14
Closes #15
Closes #16
Closes #17
Closes #18