Conversation
paf31
reviewed
Jun 8, 2017
|
|
||
| -- | Generates a random `Day` component. | ||
| genDay :: forall m. MonadGen m => m Day | ||
| genDay = genBoundedEnum |
Contributor
There was a problem hiding this comment.
Shouldn't this take a Month as an argument?
Member
Author
There was a problem hiding this comment.
Hmm, that's a good point. I guess it would need to receive the Year also, in that case.
Maybe it's fine as is though, since you can't construct an invalid Date anyway (canonicalDate will fix it, or exactDate will return Nothing) - but we could add an alternative generator that does take month/year to ensure it will be correct for a specific period.
Contributor
|
👍 One comment, LGTM otherwise.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on purescript/purescript-enums#29