Hotfix#10
Conversation
…here are any ffi errors
…o ready/hotfix-ffi
|
How did this not get caught by core-tests? |
|
Merged, and re-released as 0.3.0. Please be sure to run core-tests for any core library changes in future. |
|
Oh I see what happened. Dead code elimination removed this function because it wasn't being tested. |
|
Yep. Didn't detect it until I was updating purescript-quickcheck. :-/ PR coming shortly for core-tests to add some tests and update dependencies / fix versions. |
|
Cool, thank you. |
|
Maybe it's bower being weird, but I'm still getting the "old" 0.3.0. Any ideas? |
|
|
|
It's not working for me either, but the tag clearly includes the fix. |
|
|
|
Also ran into this, should probably also push a |
|
Agreed, can't hurt to push a new patch fix just in case. |
An FFI function had an error that wasn't detected by the build. Fixed the error, also added jsvalidate as an NPM dependency and incorporated it into the build process so the build won't complete if there are any FFI errors.
I'd suggest pushing this hotfix to the 0.3.0 tag directly, if possible. Review by @garyb etc.