Skip to content

Update to PureScript v0.13.6#162

Merged
hdgarrood merged 2 commits into
masterfrom
ps-0.13.6
May 2, 2020
Merged

Update to PureScript v0.13.6#162
hdgarrood merged 2 commits into
masterfrom
ps-0.13.6

Conversation

@hdgarrood
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread server/Main.hs Outdated
(resultMay, ws) <- runLogger' . runExceptT . flip runReaderT P.defaultOptions $ do
((P.Module ss coms moduleName elaborated exps, env), nextVar) <- P.runSupplyT 0 $ do
desugared <- P.desugar externs [P.importPrim m] >>= \case
env <- fmap fst . runWriterT $ foldM P.externsEnv P.primEnv externs
Copy link
Copy Markdown
Contributor

@natefaubion natefaubion May 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds the env for every compilation, right? Is it possible to build this once and reuse it?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah of course, yes it does.

@hdgarrood hdgarrood merged commit 686cc5d into master May 2, 2020
@thomashoneyman
Copy link
Copy Markdown
Member

With this merged, are there any steps we should take to deploy the 0.13.6 version, or is it not quite ready for that?

@hdgarrood hdgarrood deleted the ps-0.13.6 branch May 3, 2020 01:32
@hdgarrood
Copy link
Copy Markdown
Collaborator Author

I've deployed this to the DigitalOcean droplet which I intend to be the new home for Try PureScript, and it seems to work! You can try it out by adding the following lines to your /etc/hosts file:

159.65.220.76 try.purescript.org
159.65.220.76 compile.purescript.org

The only thing left to do is to update the gists: the main one still has links to all of the different backends, which no longer exist, so these links won't do anything, and a couple of the other ones have references to library functions which no longer exist, like id (which was replaced with identity).

I am coming to think that using gists for the examples is a bit awkward, since you can't do pull requests on them and access control on gists is not really a thing either. I think it would be ideal to move them inside the repo, although of course we should continue to support loading code from gists. I'll open a new issue for this.

@thomashoneyman
Copy link
Copy Markdown
Member

Ah! I hadn’t realized Try PureScript wasn’t already pointing at the new box. And I think version controlling the stable examples in this repository is a good idea.

@hdgarrood
Copy link
Copy Markdown
Collaborator Author

For now, I've just updated the gists. I think I'll switch the DNS over tomorrow unless anyone notices anything else that's broken :)

@hdgarrood
Copy link
Copy Markdown
Collaborator Author

Oh, we should probably fix #165 first too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants