Replace Milkis with Affjax#4
Merged
Merged
Conversation
jonasbuntinx
approved these changes
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milkis is a bit basic, and has proved troublesome when trying to share code between the browser and server. So this replaces it with Affjax. The internal models for requests and responses change slightly, but it still uses
simple-jsonfor JSON.Making these changes has highlighted some issues with the current design of Apiary, but I'm not sure how to address them without making the design and implementation more complex. This can be deferred until later however, provided the change to Affjax has the intended benefits.