Add RDS DBCluster MasterUsername validation#4425
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4425 +/- ##
==========================================
- Coverage 93.54% 93.40% -0.14%
==========================================
Files 418 434 +16
Lines 14145 14625 +480
Branches 2817 2874 +57
==========================================
+ Hits 13232 13661 +429
- Misses 567 594 +27
- Partials 346 370 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e2dd504 to
97714ce
Compare
- MasterUsername required when MasterUserPassword is specified - Block 'rdsadmin' on all engines (reserved by RDS) - Block 'admin' on aurora-postgresql/postgresql (reserved by engine) All constraints verified against real CloudFormation deployments. Fixes aws-cloudformation#4070
97714ce to
5e91f91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MasterUsernamerequired whenMasterUserPasswordis specified (dependentRequired)rdsadminon all engines (reserved by RDS)adminonaurora-postgresql/postgresqlengines (reserved by engine)All constraints verified against real CloudFormation deployments:
adminon aurora-postgresql → fails (reserved word used by the engine)adminon aurora-mysql → succeeds (not reserved)rdsadminon both engines → failspostgreson aurora-postgresql → succeeds (not reserved)Fixes #4070