feat(ecs): add capacityOptionType (Spot support) to ManagedInstancesCapacityProvider L2 construct by djglaser · Pull Request #36497 · aws/aws-cdk · GitHub

djglaser · 2025-12-24T15:35:45Z

Issue # (if applicable)

Description of changes

ECS is expanding configuration options for a ManagedInstances CapacityProvider by allowing users to set a CapacityOptionType. This is an enum with allowed values of ON_DEMAND and SPOT. This attribute falls under the existing ManagedInstancesCapacityProvider L2 construct.

Feature description

Capacity Option Type provides the purchasing option for the EC2 instances used in the capacity provider. Determines whether to use On-Demand or Spot instances. Valid values are ON_DEMAND and SPOT. Defaults to ON_DEMAND when not specified. Changing this value will trigger replacement of the capacity provider. For more information, see Amazon EC2 billing and purchasing options in the Amazon EC2 User Guide.

Description of how you validated changes

Added and validated unit tests
Modified existing ManagedInstances integration test to include a CapacityOptionType attribute with a value of SPOT.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

github-actions · 2025-12-24T15:38:08Z

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.

	Tests	Passed ☑️	Skipped	Failed ❌️
Security Guardian Results	24 ran	23 passed		1 failed

Test	Result
Security Guardian Results
packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/integ.managedinstances-capacity-provider.js.snapshot/integ-managedinstances-capacity-provider.template.json
ec2-no-open-security-groups.guard	❌ failure

View Security Guardian Results

github-actions · 2025-12-24T15:38:11Z

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results with resolved templates	24 ran	24 passed

Test	Result
No test annotations available

View Security Guardian Results with resolved templates

Abogical

Discarded comment

Pull request has been modified.

Co-authored-by: A. Abdel-Rahman <github@abogic.al>

Pull request has been modified.

Abogical · 2026-01-20T15:53:28Z

@Mergifyio update

mergify · 2026-01-20T15:53:34Z

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/pr-linter.yml without workflows permission

Abogical

There is a build error that needs to be checked:

https://github.com/aws/aws-cdk/actions/runs/21178046110/job/60912261759?pr=36497#step:9:1749

Error: aws-cdk-lib: aws-ecs/test/cluster.test.ts:2954:67 - error TS2345: Argument of type '{ infrastructureRole: iam.Role; ec2InstanceProfile: iam.InstanceProfile; subnets: ec2.ISubnet[]; capacityOptionType: ecs.CapacityOptionType.ON_DEMAND; }' is not assignable to parameter of type 'ManagedInstancesCapacityProviderProps'.
aws-cdk-lib:   Property 'securityGroups' is missing in type '{ infrastructureRole: iam.Role; ec2InstanceProfile: iam.InstanceProfile; subnets: ec2.ISubnet[]; capacityOptionType: ecs.CapacityOptionType.ON_DEMAND; }' but required in type 'ManagedInstancesCapacityProviderProps'.

Pull request has been modified.

mergify · 2026-01-20T21:33:12Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2026-01-20T21:33:48Z

Merge Queue Status

🚫 The pull request has left the queue (rule: default-squash) at 692b326

This pull request spent 5 minutes 5 seconds in the queue, with no time running CI.

Reason

Pull request #36497 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

#approved-reviews-by>=1
#changes-requested-reviews-by=0
any of: [🔀 queue conditions]
- all of: [📌 queue conditions of queue default-squash]
  - #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  - #approved-reviews-by>=1
  - #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  - #changes-requested-reviews-by=0

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Pull request has been modified.

mergify · 2026-01-21T15:45:53Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2026-01-21T15:46:48Z

mergify · 2026-01-21T16:37:26Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2026-01-21T16:37:45Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

aws-cdk-automation requested a review from a team December 24, 2025 15:35

github-actions Bot added repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK p2 labels Dec 24, 2025

djglaser force-pushed the djglaser/managed-spot-release branch from 624e003 to f758729 Compare December 24, 2025 15:39

pahud mentioned this pull request Dec 24, 2025

Failed CodeBuild CI - 11 PR(s) pahud/aws-cdk#17

Open

github-actions Bot mentioned this pull request Jan 1, 2026

Monthly PR metrics report #36544

Open

Abogical self-assigned this Jan 13, 2026

Abogical requested changes Jan 13, 2026

View reviewed changes

Abogical previously requested changes Jan 13, 2026

View reviewed changes

Comment thread tools/@aws-cdk/spec2cdk/temporary-schemas/us-east-1/aws-ecs-capacityprovider.json Outdated

djglaser and others added 2 commits January 20, 2026 10:20

feat(ecs): add capacityOptionType (SPOT) to ManagedInstances config

ad37571

Add CapacityOptionType description to README.md

5853b3d

djglaser force-pushed the djglaser/managed-spot-release branch from f758729 to 5853b3d Compare January 20, 2026 15:21

Abogical previously requested changes Jan 20, 2026

View reviewed changes

Comment thread packages/aws-cdk-lib/aws-ecs/lib/cluster.ts Outdated

Update packages/aws-cdk-lib/aws-ecs/lib/cluster.ts

ffa5a2f

Co-authored-by: A. Abdel-Rahman <github@abogic.al>

Abogical approved these changes Jan 20, 2026

View reviewed changes

Merge branch 'main' into djglaser/managed-spot-release

2886921

Abogical approved these changes Jan 20, 2026

View reviewed changes

Abogical previously requested changes Jan 20, 2026

View reviewed changes

Add security groups to ManagedInstancesCapacityProvider tests

382a68f

Fix README build failure

692b326

Abogical approved these changes Jan 20, 2026

View reviewed changes

Abogical self-requested a review January 20, 2026 21:36

Abogical previously requested changes Jan 20, 2026

View reviewed changes

Comment thread packages/aws-cdk-lib/aws-ecs/lib/cluster.ts Outdated

Add documentation for default value for capacityOptionType

f438501

Abogical approved these changes Jan 21, 2026

View reviewed changes

Merge branch 'main' into djglaser/managed-spot-release

3af430a

mergify Bot merged commit e8ad85b into aws:main Jan 21, 2026
20 of 23 checks passed

github-actions Bot locked as resolved and limited conversation to collaborators Jan 21, 2026

djglaser deleted the djglaser/managed-spot-release branch January 21, 2026 19:52

Conversation

djglaser commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Description of changes

Feature description

Description of how you validated changes

Checklist

Uh oh!

github-actions Bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abogical left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Abogical commented Jan 20, 2026

Uh oh!

mergify Bot commented Jan 20, 2026

❌ Mergify doesn't have permission to update

Uh oh!

Abogical left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Jan 20, 2026

Uh oh!

mergify Bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

Uh oh!

mergify Bot commented Jan 21, 2026

Uh oh!

mergify Bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

mergify Bot commented Jan 21, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

djglaser commented Dec 24, 2025 •

edited

Loading

github-actions Bot commented Dec 24, 2025 •

edited

Loading

github-actions Bot commented Dec 24, 2025 •

edited

Loading

Abogical left a comment •

edited

Loading

Abogical left a comment •

edited

Loading

mergify Bot commented Jan 20, 2026 •

edited

Loading

mergify Bot commented Jan 21, 2026 •

edited

Loading