feat(mixins-preview): align Mixins API with latest RFC proposal#36825
Merged
Conversation
aws-cdk-automation
previously requested changes
Jan 30, 2026
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
d0625a7 to
1e334d1
Compare
rix0rrr
approved these changes
Jan 30, 2026
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status✅ The pull request has been merged at 1e334d1 This pull request spent 6 seconds in the queue, with no time running CI. Required conditions to merge
|
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
The RFC for CDK Mixins was updated with several changes. This PR aligns the implementation of the preview package with the latest changes. It also includes some other API improvements to make Mixins more intuitive and consistent.
Description of changes
mustApply()with separaterequireAll()andrequireAny()methods that set expectations before callingapply(). This was a change to the RFC. To support this change, this also includes:reportgetter to track successful applications, returning an array of the newMixinApplicationinterfaceselectedConstructsgetter to see which constructs were matched by the selector.with()silently skip unsupported constructs instead of throwing, this is implementing an RFC changeapplyTo()return type fromIConstructtovoidsince mixins modify in place (RFC change)EnableVersioningtoBucketVersioningfor consistency with other S3 mixinsBucketVersioningconstructor parameter to allow suspending versioningaws-cdk-libwhich also doesn't emit sourcemaps.Description of how you validated changes
Updated existing unit tests to reflect the API changes and added new tests for
requireAll(),requireAny(), and thereportgetter.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license