Skip to content

chore: prevent hoisting of bundled dependencies#36903

Merged
mergify[bot] merged 2 commits into
mainfrom
huijbers/forgot-hosting
Feb 6, 2026
Merged

chore: prevent hoisting of bundled dependencies#36903
mergify[bot] merged 2 commits into
mainfrom
huijbers/forgot-hosting

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Feb 6, 2026

npm will refuse to bundle hoisted dependencies; dependencies are only bundled if they are directly under node_modules. Otherwise, bundling is a silent no-op.

Disable hoisting of a bundled dependency in cx-api, this will unbreak the build pipeline.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

`npm` will refuse to bundle hoisted dependencies; dependencies are only
bundled if they are directly under `node_modules`. Otherwise, bundling
is a silent no-op.

Disable hoisting of a bundled dependency in `cx-api`, this will unbreak
the build pipeline.
@rix0rrr rix0rrr requested a review from a team February 6, 2026 14:40
@github-actions github-actions Bot added the p2 label Feb 6, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team February 6, 2026 14:40
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label Feb 6, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 6, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 6, 2026

Merge Queue Status

✅ The pull request has been merged at 9d9d9db

This pull request spent 29 minutes 12 seconds in the queue, including 29 minutes 1 second running CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 6, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify Bot merged commit 9ccb548 into main Feb 6, 2026
17 of 18 checks passed
@mergify mergify Bot deleted the huijbers/forgot-hosting branch February 6, 2026 15:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants