feat: remove unbundled sources#1700
Merged
Merged
Conversation
We used to ship two of everything: - `lib` - the unbundled sources - `chai.js` - the bundle We then moved to only shipping `lib`, but this results in a slower and slightly larger package. This reverses that decision, such that we have only `index.js` (a bundle, what was `chai.js` before), and no longer have `lib`.
keithamus
previously approved these changes
Aug 22, 2025
keithamus
approved these changes
Aug 22, 2025
43081j
added a commit
that referenced
this pull request
Aug 22, 2025
* feat: remove unbundled sources We used to ship two of everything: - `lib` - the unbundled sources - `chai.js` - the bundle We then moved to only shipping `lib`, but this results in a slower and slightly larger package. This reverses that decision, such that we have only `index.js` (a bundle, what was `chai.js` before), and no longer have `lib`. * feat: move deps to dev dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to ship two of everything:
lib- the unbundled sourceschai.js- the bundleWe then moved to only shipping
lib, but this results in a slower and slightly larger package.This reverses that decision, such that we have only
index.js(a bundle, what waschai.jsbefore), and no longer havelib.BREAKING CHANGE
If we want to do any other breaks, now is the time since this'll result in a new major