feat: read detail model for iphone, ipod, ipad if the model information exist #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, How do I get this to work for me, seems the major change is with the json file and your pull request hasn't been accepted yet for whatever reason? Does this give a clear model for all the iPhone types? Thanks, |
arslan-raza-143
approved these changes
Nov 9, 2021
arslan-raza-143
approved these changes
Nov 9, 2021
arslan-raza-143
approved these changes
Nov 9, 2021
faisalman
added a commit
that referenced
this pull request
Mar 20, 2023
faisalman
added a commit
that referenced
this pull request
Mar 31, 2023
(cherry picked from commit a1d816a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is for issue #520
Support extracting information for iphone, ipod, ipad device model if there exists, to get a clear model