Skip to content

feat: add onGenerateMock transformer callback (#15429)#15433

Merged
SimenB merged 5 commits into
jestjs:mainfrom
MillerSvt:jest-on-mock-hook
Jan 15, 2025
Merged

feat: add onGenerateMock transformer callback (#15429)#15433
SimenB merged 5 commits into
jestjs:mainfrom
MillerSvt:jest-on-mock-hook

Conversation

@MillerSvt
Copy link
Copy Markdown
Contributor

@MillerSvt MillerSvt commented Dec 30, 2024 •
edited by SimenB
Loading

Summary

Add ability to modify generated mock within presets or project code (Closes #15429, thymikee/jest-preset-angular#2908)

Test plan

Run test in packages/jest-runtime/src/__tests__/runtime_mock.test.js

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Dec 30, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b709d31
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6787735ab7306c0008a1f007
😎 Deploy Preview https://deploy-preview-15433--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MillerSvt MillerSvt force-pushed the jest-on-mock-hook branch 4 times, most recently from ec88557 to 1e3405a Compare December 30, 2024 08:53
SimenB
SimenB approved these changes Jan 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, thanks!

mind adding some docs in https://github.com/jestjs/jest/blob/main/docs/JestObjectAPI.md as well?

@MillerSvt
Copy link
Copy Markdown
Contributor Author

MillerSvt commented Jan 15, 2025

Sure

@MillerSvt MillerSvt requested a review from SimenB January 15, 2025 06:58
SimenB
SimenB approved these changes Jan 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@SimenB SimenB enabled auto-merge (squash) January 15, 2025 07:01
mrazauskas
mrazauskas reviewed Jan 15, 2025
View reviewed changes
Comment thread packages/jest-environment/src/index.ts Outdated
Comment thread packages/jest-environment/src/index.ts Outdated
auto-merge was automatically disabled January 15, 2025 07:03

Head branch was pushed to by a user without write access

@MillerSvt MillerSvt requested a review from mrazauskas January 15, 2025 07:03
SimenB
SimenB reviewed Jan 15, 2025
View reviewed changes
Comment thread packages/jest-environment/src/index.ts Outdated
*
* @param cb
*/
onGenerateMock<T>(cb: (moduleName: string, moduleMock: T) => T): Jest;
Copy link
Copy Markdown
Member

@SimenB SimenB Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is duplicated now, unless I'm seeing things 😅

Copy link
Copy Markdown
Contributor Author

@MillerSvt MillerSvt Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems rebase breaks 😃

@SimenB SimenB enabled auto-merge (squash) January 15, 2025 09:22
@SimenB SimenB merged commit 3088367 into jestjs:main Jan 15, 2025
mohammednumaan pushed a commit to mohammednumaan/jest that referenced this pull request Jan 17, 2025
@MillerSvt @mohammednumaan
feat: add onGenerateMock transformer callback (jestjs#15429) (jestjs#…
a3e0165 
…15433)
@SimenB
Copy link
Copy Markdown
Member

SimenB commented Jan 30, 2025

https://github.com/jestjs/jest/releases/tag/v30.0.0-alpha.7

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

@mrazauskas mrazauskas Awaiting requested review from mrazauskas

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Add ability for presets interfere with jest auto mock

3 participants

@MillerSvt @SimenB @mrazauskas