Skip to content

Fix race condition in NodeTestTask#5427

Merged
marcphilipp merged 1 commit into
junit-team:mainfrom
jaschdoc:fix5408-race-condition
Mar 6, 2026
Merged

Fix race condition in NodeTestTask#5427
marcphilipp merged 1 commit into
junit-team:mainfrom
jaschdoc:fix5408-race-condition

Conversation

@jaschdoc
Copy link
Copy Markdown
Contributor

@jaschdoc jaschdoc commented Mar 3, 2026

Fixed by making field parentContext volatile.

Issue: #5408


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@jaschdoc jaschdoc force-pushed the fix5408-race-condition branch from 2692267 to f39476c Compare March 3, 2026 16:16
@marcphilipp marcphilipp linked an issue Mar 4, 2026 that may be closed by this pull request
@marcphilipp
Copy link
Copy Markdown
Member

Please sign off on your commits.

Moreover, please add an entry under "JUnit Platform" in
documentation/modules/ROOT/partials/release-notes/release-notes-6.0.4.adoc which should be available on your branch after a rebase or merge.

@testlens-app

This comment has been minimized.

Fixed by making field `parentContext` volatile.

Issue: junit-team#5408

Signed-off-by: Jakob Villumsen <villumsen@google.com>
@jaschdoc jaschdoc force-pushed the fix5408-race-condition branch from f39476c to f403eae Compare March 4, 2026 15:59
@testlens-app
Copy link
Copy Markdown

testlens-app Bot commented Mar 4, 2026

✅ All tests passed ✅

🏷️ Commit: f403eae
▶️ Tests: 26910 executed
⚪️ Checks: 15/15 completed


Learn more about TestLens at testlens.app.

@jaschdoc
Copy link
Copy Markdown
Contributor Author

jaschdoc commented Mar 4, 2026

Thank you for the clarification. Both should be done now.

@jaschdoc
Copy link
Copy Markdown
Contributor Author

jaschdoc commented Mar 6, 2026

@marcphilipp, is there anything else I should do or should I request a review from someone? :)

@marcphilipp marcphilipp merged commit cdd4d24 into junit-team:main Mar 6, 2026
18 checks passed
@marcphilipp
Copy link
Copy Markdown
Member

@marcphilipp, is there anything else I should do or should I request a review from someone? :)

Sorry for the wait! I was just busy with other things.

Thank you for finding this issue and fixing it! 👍

@jaschdoc
Copy link
Copy Markdown
Contributor Author

jaschdoc commented Mar 6, 2026

No worries. Cheers!

@jaschdoc jaschdoc deleted the fix5408-race-condition branch March 6, 2026 11:59
marcphilipp pushed a commit that referenced this pull request Apr 25, 2026
Fixed by making field `parentContext` volatile.

Issue: #5408

Signed-off-by: Jakob Villumsen <villumsen@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential race condition in NodeTestTask with parallel execution

2 participants