Fix race condition in NodeTestTask#5427
Merged
Merged
Conversation
2692267 to
f39476c
Compare
Member
|
Please sign off on your commits. Moreover, please add an entry under "JUnit Platform" in |
This comment has been minimized.
This comment has been minimized.
Fixed by making field `parentContext` volatile. Issue: junit-team#5408 Signed-off-by: Jakob Villumsen <villumsen@google.com>
f39476c to
f403eae
Compare
✅ All tests passed ✅🏷️ Commit: f403eae Learn more about TestLens at testlens.app. |
Contributor
Author
|
Thank you for the clarification. Both should be done now. |
Contributor
Author
|
@marcphilipp, is there anything else I should do or should I request a review from someone? :) |
marcphilipp
approved these changes
Mar 6, 2026
Member
Sorry for the wait! I was just busy with other things. Thank you for finding this issue and fixing it! 👍 |
Contributor
Author
|
No worries. Cheers! |
marcphilipp
pushed a commit
that referenced
this pull request
Apr 25, 2026
Fixed by making field `parentContext` volatile. Issue: #5408 Signed-off-by: Jakob Villumsen <villumsen@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed by making field
parentContextvolatile.Issue: #5408
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations