Skip to content

Allow for default dialect id not to be specified and throw an exception#1212

Merged
stevehu merged 1 commit into
networknt:masterfrom
justin-tay:gh1206
Nov 8, 2025
Merged

Allow for default dialect id not to be specified and throw an exception#1212
stevehu merged 1 commit into
networknt:masterfrom
justin-tay:gh1206

Conversation

@justin-tay
Copy link
Copy Markdown
Collaborator

Closes #1206

Allows for a default dialect not to be specified.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.99%. Comparing base (48ca3c2) to head (ab66335).
⚠️ Report is 120 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1212      +/-   ##
============================================
- Coverage     78.90%   77.99%   -0.91%     
+ Complexity     1965     1930      -35     
============================================
  Files           172      201      +29     
  Lines          6352     6772     +420     
  Branches       1255     1191      -64     
============================================
+ Hits           5012     5282     +270     
- Misses          867     1050     +183     
+ Partials        473      440      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stevehu stevehu merged commit cbc4caa into networknt:master Nov 8, 2025
4 checks passed
@sschuberth
Copy link
Copy Markdown

Closes #1206

Allows for a default dialect not to be specified.

Is #1206 really the correct issue to close here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why was SpecificationVersionDetector moved to test in 2.0?

4 participants