Skip to content

Fix issue in the GitLab provider#1979

Merged
mrT23 merged 1 commit into
The-PR-Agent:mainfrom
emmanuel-ferdman:main
Aug 6, 2025
Merged

Fix issue in the GitLab provider#1979
mrT23 merged 1 commit into
The-PR-Agent:mainfrom
emmanuel-ferdman:main

Conversation

@emmanuel-ferdman
Copy link
Copy Markdown
Contributor

@emmanuel-ferdman emmanuel-ferdman commented Aug 6, 2025

User description

PR Summary

This small PR fixes the syntax error in the GitLab provider accidentally added in commit 65457b2.


PR Type

Bug fix


Description

  • Fix syntax error in GitLab provider authentication

Diagram Walkthrough

flowchart LR
  A["GitLab Provider"] --> B["OAuth Token Config"]
  B --> C["Add Missing Comma"]
  C --> D["Fixed Syntax"]
Loading

File Walkthrough

Relevant files
Bug fix
gitlab_provider.py
Fix missing comma in oauth_token parameter                             

pr_agent/git_providers/gitlab_provider.py

  • Add missing comma after oauth_token=gitlab_access_token parameter
  • Fix syntax error in GitLab instance creation
+1/-1     

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@qodo-free-for-open-source-projects
Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
✅ No TODO sections
🔒 No security concerns identified
⚡ No major issues detected

@qodo-free-for-open-source-projects
Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@emmanuel-ferdman
Copy link
Copy Markdown
Contributor Author

emmanuel-ferdman commented Aug 6, 2025

@mrT23 @Mr-jing can you please check it out once you get the chance? It's relevant to your recent changes. thanks 🙌

@Mr-jing
Copy link
Copy Markdown
Contributor

Mr-jing commented Aug 6, 2025

@mrT23 @Mr-jing can you please check it out once you get the chance? It's relevant to your recent changes. thanks 🙌

@emmanuel-ferdman
Yes,It was because a semicolon was omitted when merging the codes.
See:65457b2#diff-35acba7a2829983fcf3c3c6a69b135988227e503ccdfa94366d1b48fcbbb0a31R53
But,I don't have the authority. @mrT23 Sorry, if I had merged the main branch into my own branch earlier, perhaps this problem could have been avoided.

@mrT23
Copy link
Copy Markdown
Contributor

mrT23 commented Aug 6, 2025

👍

@mrT23 mrT23 merged commit 96435a3 into The-PR-Agent:main Aug 6, 2025
@mrT23
Copy link
Copy Markdown
Contributor

mrT23 commented Aug 6, 2025

My bad. failed to solve manualy a conflict

@Mr-jing
Copy link
Copy Markdown
Contributor

Mr-jing commented Aug 6, 2025

@emmanuel-ferdman @mrT23 Thank you! Brother, aren't you going to sleep?😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants