fix: stricter type narrowing for head schema#665
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #527
❓ Type of change
📚 Description
The head schema types were too loose —
<base>accepted empty objects,<link>didn't narrow byrel, and attributes likelang/inputmode/targetwere plain strings with no autocomplete. This tightens type narrowing across the schema so that discriminated unions (e.g.Linkbyrel,Baserequiringhrefortarget,Metabyname/property/http-equiv) provide better IDE autocomplete and catch invalid combinations at the type level.Examples of code that now errors
Empty
<base>(must providehrefortarget)Mixing
name+propertyon<meta>charsetmeta withcontentExternal script with
textContentJSON-LD with
src<link rel="mask-icon">missing requiredcolor<noscript>with bothtextContentandinnerHTML<link>withouthref(GenericLink now requires it)