Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: canonical/data-platform-workflows
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2
Choose a base ref
...
head repository: canonical/data-platform-workflows
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3
Choose a head ref
  • 5 commits
  • 17 files changed
  • 1 contributor

Commits on Jul 28, 2023

  1. breaking(build_charms_with_cache.yaml): Remove charms output (JSON … 

    …string of charms built) (#58)

Instead of using the JSON string, integration tests should instead
download the GitHub artifact and check if a *.charm file exists

If there are multiple *.charm files in a directory, the integration test
job should use an input to determine which *.charm file to select
(example input: Ubuntu version)

This change makes build_charms_with_cache.yaml more
consistent/interchangeable with build_charm_without_cache.yaml
    @carlcsaposs-canonical
    carlcsaposs-canonical authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    557fea4 View commit details
    Browse the repository at this point in the history

  2. compatible(build_charms_with_cache.yaml): Add pytest-operator plugin … 

    …to override `build_charm` (#63)

Add reusable pytest plugin to override pytest-operator's
`ops_test.build_charm()` to return cached *.charm file instead of
building new *.charm file.

Previously, callers of build_charms_with_cache.yaml needed to add a
`conftest.py` to override `ops_test.build_charm()`. Now, they can just
install a plugin (which is versioned along with the workflow).

More details about previous implementation:
https://discourse.charmhub.io/t/faster-integration-tests-with-github-caching/8782
    @carlcsaposs-canonical
    carlcsaposs-canonical authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d0e21c6 View commit details
    Browse the repository at this point in the history

  3. patch: Update __sync_issue_to_jira.yaml to v3 (#66)

    @carlcsaposs-canonical
    carlcsaposs-canonical authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2aa7fe3 View commit details
    Browse the repository at this point in the history

  4. patch: Update version in documentation example to v0 (#67) 

    The version no longer needs to be updated after a major release

`v0` is not a version on this repository. If someone copy-pastes an
example, it will fail instead of using an old version.
    @carlcsaposs-canonical
    carlcsaposs-canonical authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    ffac7cf View commit details
    Browse the repository at this point in the history

  5. patch: Add pytest_plugins to CONTRIBUTING.md public interface definit… 

    …ion (#68)
    @carlcsaposs-canonical
    carlcsaposs-canonical authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    5e4d492 View commit details
    Browse the repository at this point in the history
Loading