Added console group APIs to NullConsole#9024
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
SimenB
left a comment
There was a problem hiding this comment.
Thanks!
Could you add an entry to the changelog?
|
ping @eranimo :) |
Codecov Report
@@ Coverage Diff @@
## master #9024 +/- ##
=======================================
Coverage 64.69% 64.69%
=======================================
Files 277 277
Lines 11701 11701
Branches 2873 2873
=======================================
Hits 7570 7570
Misses 3514 3514
Partials 617 617Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #9018
Summary
This PR fixes the
--silentCLI option, which previously didn't silence console group calls.