fix: use file urls when calling import()#9558
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9558 +/- ##
=======================================
Coverage 65.04% 65.04%
=======================================
Files 286 286
Lines 12123 12123
Branches 3004 3004
=======================================
Hits 7885 7885
Misses 3600 3600
Partials 638 638
Continue to review full report at Codecov.
|
This was referenced Apr 16, 2020
This was referenced Apr 25, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9544.
Test plan
I've tested this on windows. We have an integration test for this, but we only run windows CI with node v12...
EDIT: As can be seen in #9540, this was failing for node 13 on windows, but now passing