[jest-runner] Don't print warning to stdout when using --json#9843
Merged
Conversation
SimenB
approved these changes
Apr 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #9843 +/- ##
==========================================
- Coverage 64.52% 64.51% -0.02%
==========================================
Files 290 290
Lines 12325 12325
Branches 3048 3048
==========================================
- Hits 7953 7951 -2
- Misses 3732 3733 +1
- Partials 640 641 +1
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This warning should go to
stderr, otherwise when you have a test that leaks while using--jsonit will produce invalid JSON when reading thestdoutof a Jest process.Test plan
This regressed in Jest through #8206 and made Jest on CI at FB fail. Verified this change fixes it.