Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/python-pubsub
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.5.0
Choose a base ref
...
head repository: googleapis/python-pubsub
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.6.0
Choose a head ref
  • 10 commits
  • 38 files changed
  • 5 contributors

Commits on May 19, 2021

  1. Configuration menu
    Copy the full SHA
    de5429a View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. fix: ACK deadline set for received messages can be too low (#416)

    Fixes #413.
    
    This PR makes sure that the ACK deadline set for the received messages is always consistent with what the leaser uses internally when extending the ACK deadlines for the leased messages.
    
    See the issue description and a [comment](#413 (comment)) explaining a possible sequence of events that lead to a bug.
    
    **PR checklist**
    - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-pubsub/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
    - [x] Ensure the tests and linter pass
    - [x] Code coverage does not decrease (if any source code was changed)
    - [x] Appropriate docs were updated (if necessary)
    plamut authored May 26, 2021
    Configuration menu
    Copy the full SHA
    e907f6e View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Configuration menu
    Copy the full SHA
    c825789 View commit details
    Browse the repository at this point in the history
  2. test: presubmit against Lite samples (#425)

    * test: presubmit against Lite samples
    
    * mark new presubmit test required
    anguillanneuf authored Jun 11, 2021
    Configuration menu
    Copy the full SHA
    c757a5e View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. docs: block until the streaming pull shuts down (#424)

    Fixes #423.
    
    If subscriber client is used as a context manager, we need to block until the shutdown is complete before leaving the `with` block. See the issue description for more details.
    
    **PR checklist:**
    - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-pubsub/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
    - [x] Ensure the tests and linter pass
    - [x] Code coverage does not decrease (if any source code was changed)
    - [x] Appropriate docs were updated (if necessary)
    plamut authored Jun 14, 2021
    Configuration menu
    Copy the full SHA
    d0d0b70 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Configuration menu
    Copy the full SHA
    691a3dd View commit details
    Browse the repository at this point in the history
  2. feat: support customizable retry and timeout settings on the publishe…

    …r client (#299)
    
    * feat: allow retry and timeout settings on publisher client
    
    * build: update generated code and update doc
    
    * Propagate publish timeout to the RPC call
    
    * test publisher client
    
    * Fix timeout parameter type in docstrings
    
    * Apply timeout changes to async publisher client
    
    * Introduce TimeoutType type alias
    
    * Update PublisherOptions docs
    
    * Use type alias for timeout in upgrading guide
    
    * Widen timeout types in generated publisher clients
    
    * Use TimeoutType in handwritten code
    
    * Remove redundant backslash
    
    * Use DEFAULT as a defualt timeout in base sequencer
    
    * Do not accept plain None as a valid timeout
    
    Using no timeout is not a good idea, but if one really wants to,
    they can pass it in as ConstantTimeout(None).
    
    As a side effect, the logic of converting a constant into a
    COnstantTimeout instance can be removed, as this is already handled
    in api-core for int and float values.
    
    Co-authored-by: Carlos de la Guardia <cguardia@yahoo.com>
    plamut and cguardia authored Jun 15, 2021
    Configuration menu
    Copy the full SHA
    7597604 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. sample: add publish flow control sample and other nits (#429)

    * sample: add publish flow control sample and other nits
    
    * restore changes in untouched files
    
    * address peter's comments
    anguillanneuf authored Jun 17, 2021
    Configuration menu
    Copy the full SHA
    0df7c96 View commit details
    Browse the repository at this point in the history
  2. fix: threads can skip the line in publisher flow controller (#422)

    * Add publisher flow controller test for FIFO order
    
    * Simplify _run_in_daemon() test helper
    
    * Fix message slots not acquired in FIFO order
    
    * Unify the logic for distributing any free capacity
    
    * Use OrderedDict for the FIFO queue
    
    This allows to hold the queue of threads and their reservation data
    in a single structure, no need for the separate deque and reservations
    dict.
    plamut authored Jun 17, 2021
    Configuration menu
    Copy the full SHA
    ef89f55 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. chore: release 2.6.0 (#428)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] authored Jun 21, 2021
    Configuration menu
    Copy the full SHA
    18cebd4 View commit details
    Browse the repository at this point in the history
Loading