Skip to content

xds: include node ID in RPC failure status messages from the XdsClient#9099

Merged
sergiitk merged 3 commits intogrpc:masterfrom
sergiitk:xds-error-status-with-node-id
Apr 21, 2022
Merged

xds: include node ID in RPC failure status messages from the XdsClient#9099
sergiitk merged 3 commits intogrpc:masterfrom
sergiitk:xds-error-status-with-node-id

Conversation

@sergiitk
Copy link
Copy Markdown
Member

No description provided.

@sergiitk sergiitk force-pushed the xds-error-status-with-node-id branch from b0bd2dd to 33791ca Compare April 21, 2022 01:32
@sergiitk sergiitk marked this pull request as ready for review April 21, 2022 01:36
Comment thread xds/src/main/java/io/grpc/xds/ClientXdsClient.java Outdated
Copy link
Copy Markdown
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread xds/src/main/java/io/grpc/xds/ClientXdsClient.java Outdated
Copy link
Copy Markdown
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment could be tweaked

@sergiitk sergiitk requested a review from ejona86 April 21, 2022 15:59
Comment thread xds/src/main/java/io/grpc/xds/XdsClient.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsClient.java Outdated
@sergiitk sergiitk requested a review from ejona86 April 21, 2022 16:26
@sergiitk sergiitk enabled auto-merge (squash) April 21, 2022 16:52
@sergiitk sergiitk merged commit a582910 into grpc:master Apr 21, 2022
@sergiitk sergiitk deleted the xds-error-status-with-node-id branch April 21, 2022 17:00
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants