fix(core): regression register ts transpiler for local plugin#22964
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1b2131b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
…gin-ts-transpiler
AgentEnder
left a comment
There was a problem hiding this comment.
Good catch @Roozenboom... Can you move the implementation to inside readPluginPackageJson? We already register the transpiler correctly in other cases.
Hi @AgentEnder, I updated the PR and moved the implementation to readPluginPackageJson. Please let me know if this is ok like this. |
(cherry picked from commit abaad32)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This change solves a regression after #22527 in NX 18.3.x with registering the ts transpiler for local plugins.
In the deleted file packages/nx/src/utils/nx-plugin.ts the method registerPluginTSTranspiler was called on line 461 1f04cde#diff-4cb86fce6ea77ce0e318878f99d35ca09197cd67f2b4024a996d41bba47d3ea2L460-L462
This part was missing in the replacement file packages/nx/src/project-graph/plugins/loader.ts around line 120
https://github.com/nrwl/nx/pull/22527/files#diff-42e02f59c2df8000df3ad944ae8a5d21b25c9593087666c8e6577cce2b17faecR120
Current Behavior
ts transpiler is not registered for local plugin generators that use a directory structure with index.ts
Expected Behavior
The ts transpiler is registered for local plugins
Related Issue(s)
Fixes #22958